Seed Phrase Recovery #1394
Closed
Seed Phrase Recovery #1394
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # src/routes.ts # src/ui/recovery/container/seedPhrase.tsx # src/ui/settings/containers/settings.tsx
JolocomTheme should be imported from the generic theme file, as the font name is different on iOS and Android.
We are using position relative and absolute to put the mnemonic phrase in the middle of the screen, using the length of the current word with an average character length. There may be a way to calculate the actual rendered length of the word and use that to position more accurately.
…rase Fix/recovery/center mnemonic phrase
# Conflicts: # src/actions/registration/index.ts # src/routes.ts # src/ui/landing/containers/landing.tsx # src/ui/registration/containers/seedPhrase.tsx # src/ui/settings/containers/settings.tsx # tests/actions/registration/__snapshots__/index.test.ts.snap # tests/ui/containers/__snapshots__/seedPhrase.test.tsx.snap # tests/ui/containers/landing.test.tsx
mnzaki
reviewed
Aug 12, 2019
package.json
Outdated
| @@ -55,7 +55,7 @@ | |||
| "yarn": "^1.16.0" | |||
| }, | |||
| "scripts": { | |||
| "start": "node node_modules/react-native/local-cli/cli.js start", | |||
| "start": "adb reverse tcp:8081 tcp:8081 && node node_modules/react-native/local-cli/cli.js start", | |||
There was a problem hiding this comment.
Why this? metro takes care of this automatically
There was a problem hiding this comment.
Does it? it only worked for me with run:android but when I just use start I got a Could not connect to development server error...
There was a problem hiding this comment.
yeah I've had to run adb reverse almost every time
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Open TODOs:
New Features