Recovery initialization #1418
Merged
Recovery initialization #1418
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # src/routes.ts # src/ui/recovery/container/seedPhrase.tsx # src/ui/settings/containers/settings.tsx
JolocomTheme should be imported from the generic theme file, as the font name is different on iOS and Android.
We are using position relative and absolute to put the mnemonic phrase in the middle of the screen, using the length of the current word with an average character length. There may be a way to calculate the actual rendered length of the word and use that to position more accurately.
…rase Fix/recovery/center mnemonic phrase
# Conflicts: # src/actions/registration/index.ts # src/routes.ts # src/ui/landing/containers/landing.tsx # src/ui/registration/containers/seedPhrase.tsx # src/ui/settings/containers/settings.tsx # tests/actions/registration/__snapshots__/index.test.ts.snap # tests/ui/containers/__snapshots__/seedPhrase.test.tsx.snap # tests/ui/containers/landing.test.tsx
# Conflicts: # package.json # src/actions/generic/index.ts # src/routes.ts
This was referenced Aug 21, 2019
Closed
chunningham
requested review from
chunningham
and removed request for
mnzaki and
saifahn
chunningham
suggested changes
Aug 22, 2019
# Conflicts: # src/routes.ts # src/ui/documents/containers/documents.tsx # src/ui/home/components/records.tsx # src/ui/home/containers/claims.tsx # src/ui/recovery/components/seedPhrase.tsx # src/ui/settings/components/settings.tsx # tests/ui/components/__snapshots__/seedPhrase.test.tsx.snap # tests/ui/containers/__snapshots__/claims.test.tsx.snap
# Conflicts: # src/ui/home/components/records.tsx # src/ui/recovery/components/seedPhrase.tsx # tests/ui/components/__snapshots__/seedPhrase.test.tsx.snap
This was referenced Sep 12, 2019
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moving the screen that shows the seed phrase to the settings screen