Skip to content

Commit

Permalink
pkp#8710 Updated comments
Browse files Browse the repository at this point in the history
  • Loading branch information
jonasraoni committed Aug 25, 2023
1 parent 3ff69bf commit 73cb3b9
Showing 1 changed file with 4 additions and 2 deletions.
6 changes: 4 additions & 2 deletions classes/submission/Collector.php
Original file line number Diff line number Diff line change
Expand Up @@ -517,6 +517,7 @@ public function getQueryBuilder(): Builder
->whereIn('pc.category_id', $this->categoryIds);
}

// Filter by is reviewed by
if ($this->isReviewedBy !== null) {
// TODO consider review round and other criteria; refactor query builder to use ->when
$q->when($this->isReviewedBy === self::UNASSIGNED, function (Builder $q) {
Expand All @@ -527,12 +528,13 @@ public function getQueryBuilder(): Builder
}

// By any child pub object's DOI status
// Filter by any child pub object's DOI status
$q->when($this->doiStatuses !== null, fn (Builder $q) => $this->addDoiStatusFilterToQuery($q));

// By whether any child pub objects have DOIs assigned
// Filter by whether any child pub objects have DOIs assigned
$q->when($this->hasDois !== null, fn (Builder $q) => $this->addHasDoisFilterToQuery($q));

// By whether any child pub objects have DOIs assigned
// Filter out excluded submission IDs
$q->when($this->excludeIds !== null, fn (Builder $q) => $q->whereNotIn('s.submission_id', $this->excludeIds));

// Limit and offset results for pagination
Expand Down

0 comments on commit 73cb3b9

Please sign in to comment.