Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rust support #1

Merged
merged 515 commits into from
Aug 21, 2017
Merged

Rust support #1

merged 515 commits into from
Aug 21, 2017

Conversation

hollinwilkins
Copy link

@hollinwilkins hollinwilkins commented Aug 21, 2017 •
edited
Loading

Hey @josephDunne, I wanted to help get this PR ready for merging into the google codebase. As a start, I fixed all of the merge conflicts with master. Next up, I need to make sure all of the codegen is still working as expected. Would it be possible for us to generate a TODO list that we can work down before Rust support is ready?

Thank you!

  • Hollin

Wouter van Oortmerssen and others added 30 commits October 17, 2016 10:46
Merge branch 'master' of https://github.com/google/flatbuffers
2beb985
Fixed broken traits codegen for --scoped-enums.
b5c6227 
Change-Id: I5f538d12ea37d11d2e239ddde32eefcdd91e347b
Tested: on Linux.
Fixed unused variable warnings, and made sure they are on.
606098c 
Tested on Linux.

Change-Id: Ie18d6857f9ae8b1c3953a116203b4a8bb70a2ede
Fixed lambda return value error on VS2010.
22e8707 
Change-Id: I6d0e8469bfa5b4c8a3f1cb119e186f4cf62c76ae
Added functionality to obtain a buffer pointer from a root.
6862b2f 
Change-Id: Ia63e41d0304e8668ea4ce09a4c31dd999eb96994
Tested: on Linux.
Bug: 32218623
@blep
Java: fix unsigned default value code generation and add 'L' suffix f…
5b5fcbf 
…or long default value (google#4051)

* Java: emit "signed" equivalent of unsigned default value in generated code and add "L" suffix to long default value.

* Updated generated code

* Only convert ulong to "signed" equivalent. ubyte and ushort don't need specific handling as "user facing" type is int. uint need 'L' suffix as "user facing" type is long.

* Added missing cast to primitive type of default value which is in "user facing" type in builder.add<type>() calls.

* Do not cast default value to actual type in C#.
@cajun-rat
Fix Closure Compiler warnings (google#4067)
d8944e4 
* Make parameter order in jsdocs match function

When the order doesn't match the Google Closure Javascript compiler generates
warnings

* Prefix optional parameters with opt_

The Closure Compiler emits warnings when this isn't the case
Made nesting vs inline clearer in the docs.
dae513e 
Also fixed structs not being created inline in the tutorial,
which would actually have bad consequences if used.

Change-Id: Idce215c61a1b24a297cee76f625052bb2722e970
Merge branch 'master' of https://github.com/google/flatbuffers
43ba7c6
Fixed STLPort error for missing vector::data()
e31fbb0 
Change-Id: I06fb61edf018adf0f26a81de4596b4972226e466
Tested: on Android.
Bug: 30263829
Change docs to not encourage use of 1 byte buffers.
af21b90 
Change-Id: Ib0b1692044f35e374a0f7c0359c94319f4a25619
@benssson
Fixed javascript helper for typed arrays of scalars not taking into (g…
cf0d782 
…oogle#4068)

account underlying buffer's byte offset.
@gitter-badger
Add Gitter badge (google#4075)
76ae10d
Fixes to support GCC 4.4.7
290e9f2 
Fixed generation of a trailing comma and removed unnecessary use of a lambda.

Change-Id: I9993f6eb83e2ebc36fc40295a2059c340c1fbe03
Tested: on Linux.
Merge branch 'master' of https://github.com/google/flatbuffers
c2050aa
@ThePrimeagen
chore(lint) (google#4079)
d298adc 
* chore(lint)

I accidentally let 2 pieces of lint in with my generated code.

* fix(generate-code): I did not generate all the required code for tests.
@garretmcgraw
Making flatbuffers JSON parsing deal with unexpected null values when…
c05803b 
… unknown JSON is allowed. (google#4083)
@devantoine
[PHP] Use mb_detect_encoding when available (google#3952)
dbecdf2 
I've faced an issue where I want to serialize UTF-8 emojis and FlatBufferBuilder::is_utf8 would return false on them.
I was not able to add the corresponding hexadecimal code because I don't understand how the whole thing works but what i've done is using the `mb_detect_encoding` function which handles correctly all supposed UTF-8 characters.
@benssson
Fixed javascript helper for typed arrays of scalars not taking into (g…
5608be0 
…oogle#4068)

account underlying buffer's byte offset.
@gitter-badger
Add Gitter badge (google#4075)
c437739
Merge branch 'master' of https://github.com/google/flatbuffers
d342918 
Change-Id: I02b00b22cdd2d1bd32de3273ff69185c9b0f4e5b
Allows structs to be stored directly as member variables.
641b397 
Introduce a "native_inline" attribute that can be applied on fields that are structs.
This results in NativeTable code generation that sets the struct "inline" rather than
storing it in a pointer.

From cl/140527470.

Change-Id: I208724f552b8b921b20923e0bf82f42cb3582416
Adds typedefs and functions to help write generic code.
bc2ec71 
The following changes have been made to the C++ codegen to enable writing generic code
that uses the Table and NativeTable types.

- Adds TableType and NativeTableType typedefs to NativeTable and Table structs.
- Adds GetFullyQualifiedName() to NativeTables if --gen-name-strings is set.
- Adds a static Pack function to Tables that simply calls the global CreateX functions.

See cr/140391505 as an example of improved usage.

From cl/140529288.

Change-Id: Idec137c16129e15c1783f94fabdcea24aeeaaef6
@jronak
Support for Golang GRPC (Experimental) (google#4082)
a31ddd2 
* support for grpc golang

* refactored grpc go generator

* added grpc-go test and refactored

* refactored idl_gen_grpc.cpp

* fixed grpc generate method name

* refactored flatc and fixed line length issue

* added codec to go lib and fixed formatting issues

* fixed spacing issues
@rw
Merge pull request google#3977 from gonzaloserrano/feature/go-generic…
92a6ae9 
…-deserialitzation

Add a generic way to deserialize a flatbuffer in Go.
@rw
Merge pull request google#3791 from mmastrac/master
b59aafc 
Avoid unsafe when sizing types
@rw
Create basic issue template (google#4107)
0de4f3f 
* Create basic issue template

* Update ISSUE_TEMPLATE.md
@manolama
Restore the ''import "unsafe'' removed in 36daedf.
dc5975b 
This was causing build failures with tools dependent on Flatbuffers in Go.
E.g.
go/src/github.com/google/flatbuffers/go/sizes.go:50: undefined: unsafe in unsafe.Pointer
@rw
Merge pull request google#4112 from manolama/tweaks
059661b 
Restore the ''import "unsafe'' removed in 36daedf…
@ricardoquesada @aardappel
add weapon + equipment to json example (google#4114)
6301da7 
update json with documentation

removed comments
rouzier and others added 26 commits August 4, 2017 08:04
@rouzier @aardappel
[c++] Add support for boolean types in flexbuffers (google#4386)
a2b1bfc 
* Add support for boolean types in flexbuffers

* Simplify casting number <=> boolean

* Added comments for tests

* Add proper support for Booleans

* Bad rebase

* No special case for strings

* Removed unused test

* Simplify logic
@aardappel
Public accessor for buffer size of flexbuffers::Builder
a64d968 
Change-Id: Iff7895aebeba9c2940e26a3edbdf2d3f1b0d9b17
@aardappel
Linked to Mikkel's binary format documentation.
8a2cc7c 
Change-Id: I5054e37833d59bbe925cac2000a453fbee8ef54b
@aardappel
Added missing generated code from past commits.
917ff81 
Change-Id: I43e8de5a2ac224836a79661cc03bf37ac6d509fe
@aardappel
Fixed clang-tidy warnings.
7fe2812 
Change-Id: Ib94ef29254c116b60e4ff298baa2ce323ac9655c
Tested: on Linux.
@aardappel
Misc documentation fixes.
4b27c92 
Change-Id: Id7be5baba7d8a11ca050e8d94d95857406690378
@aardappel
Forgot to update pom.xml in recent 1.7.1 release.
8dc1641 
Change-Id: Ia6d6967546c0a2a5340a93e54c46d2630fff92fe
@aardappel
Make it an error if a field has the same name as a table.
8a58aaf 
Change-Id: Ie5a3bb5a3643cd48e1cc75fe170a7b8a7c2cc8ed
Tested: on Linux.
@aardappel
Make flatc not silently skip schema files not ending in .fbs
a6a3f59 
Change-Id: I58463b321703b2ef0dc3f3062633909b86eca1a9
Tested: on Linux.
@krojew
Copying required field to union type vector (google#4407)
7cc72e4 
* Eclipse ignore

* TypeScript support

* Prefixing enums

* Test results

* Merged JS and TS generators

* Fixed AppVeyor build problems

* Fixed more AppVeyor build problems

* Fixed more AppVeyor build problems

* Changed TS flag to options struct

* Storing options by value

* Removed unneeded const

* Re-export support for unions

* Uint support

* Casting bools to numbers for mutation

* TS shell tests

* Reverted generates js test file to original version

* Backing up js tests and properly generating test data

* Not importing flatbuffers for TS test generation

* Not overwriting generated js for tests

* AppVeyor test fixes

* Generating the most strict TS code possible

* Not returning null when creating vectors

* Not returning null from struct contructors

* Copying required field to union type vector

* Removed unneccessary bool
@krojew
Vector of unions for TS/JS and PHP (google#4404)
46bb05d 
* Eclipse ignore

* TypeScript support

* Prefixing enums

* Test results

* Merged JS and TS generators

* Fixed AppVeyor build problems

* Fixed more AppVeyor build problems

* Fixed more AppVeyor build problems

* Changed TS flag to options struct

* Storing options by value

* Removed unneeded const

* Re-export support for unions

* Uint support

* Casting bools to numbers for mutation

* TS shell tests

* Reverted generates js test file to original version

* Backing up js tests and properly generating test data

* Not importing flatbuffers for TS test generation

* Not overwriting generated js for tests

* AppVeyor test fixes

* Generating the most strict TS code possible

* Not returning null when creating vectors

* Not returning null from struct contructors

* Vector of unions for ts/js

* Sanity check for languages

* Indentation fix + output test files

* Vectors of unions for php

* Fixes to union vector handling + tests
@aardappel
Added missing generated code.
ffddbdc 
Change-Id: I7201d6891f56094178656a76bf0f87cf36d12554
@aardappel
Added VS crtdbg memory leak tracking
d5f5d38
@rouzier
Internal doc (google#4409)
b4e9109 
* Add information about flexbuffer bool and null encoding

* Fix spelling errors

* Fix encoding example for flexbuffer map
@rouzier
C++ Add new type vector_bool flexbuffers (google#4410)
76744a4 
* Add new type vector_bool

* Update stl_emulation.h

Fix Is same typo

* Update stl_emulation.h
@aardappel
Fixed root_type leaking in from included files.
dca33dd 
Change-Id: I9378e375901f8a883eaeb2182955d690c358ed4b
Tested: on Linux.
@aardappel
Cleaned up test output.
d761131 
Change-Id: I4bec0e728cc162aa3f19091a0d154124ffbccdff
@aardappel
Fixed file_identifier/extension leaking from included file.
432e758 
Change-Id: I470143411e4ce6322e018a27bcc9cd40c15d9bf1
Tested: on Linux.
@aardappel
Missing FieldDef initializer.
801e1b7 
Change-Id: I5ed1f77868e201d7231102a106e08f3376b6adcf
@aardappel
Fixed up grammar.md with rpc's and new scalar types.
ad0f48d 
Change-Id: Ie2965f48810bf24cccf098b69a9d471583efc3bf
@aardappel
Further grammar.md fixes: union types, idents, string constants.
00d726f 
Change-Id: I51db0511c52c79f2b322a1fdef798b061941887b
@aardappel
Fixed .proto -> .fbs translating type bytes incorrectly.
69776b9 
Change-Id: Idb607360123d12c73dd1e045305007120b12131b
Tested: on Linux.
@aardappel
Explained GetRoot<Monster> vs GetMonster.
f779962 
Change-Id: Ic302096c07551b5c1aff0b261a329c46964cf337
@aardappel
Noted that benchmarks are for C++
2f2e4cc 
Change-Id: I12fbba7ffd2db47502a05eb06cedab49fd99c366
@bluekyu
Fix use of min and max when Windows.h is imported (google#4411)
513958e
@hollinwilkins
Merge branch 'rust_support' of github.com:josephDunne/flatbuffers
d425681
@josephDunne
Copy link
Owner

Hi and thanks for the help! I will definitely go through the project tonight and create issues that need to be resolved before we can merge into the google code base

@josephDunne josephDunne merged commit 0ec9ff2 into josephDunne:rust_support Aug 21, 2017
@josephDunne
Copy link
Owner

Here is a starter:

  • Rust 1.15 introduces custom derive into stable rust - we should use that to derive flatbuffers builders from structs and enums. This is better than the macro system i was using. It will also reduce the amount of c++ code generation we need to maintain.
  • Update flatc code generation
  • Write more tests. Original feedback was that we need a fuzz test or at least test parity with the go implementation
  • I would like to redo the code in the iter.rs module
  • Implement more of the standard rust traits like ToOwned Hash etc where appropriate

optional stuff:

  • Flexbuffers
  • gRPC (perhaps best done in a separate crate)
  • I see some code in the merge discussing stores not sure if this is a Go specific thing

I will take some more time and create tickets. @hollinwilkins can you add to the above?

@hollinwilkins
Copy link
Author

@josephDunne Not sure if I have anything to add yet, I need to work on a few of these issues first then I will be more helpful. Let me know when you get the issues setup and we can start working through them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.