Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement better search issue#341 #9

Closed
wants to merge 99 commits into from
Closed

Implement better search issue#341 #9

wants to merge 99 commits into from

Conversation

julianbopp
Copy link
Collaborator

@julianbopp julianbopp commented Dec 22, 2021 •
edited
Loading

The issue was to implement a better search #Issue 341. koppor#341
It was mentioned to implement something like this:

image

The following things have been added:

  • The branch refine-search from
  • Add support for Lucene as search syntax Add support for Lucene as search syntax JabRef/jabref#8206 has been added in order to have lucene syntax support.
  • Added popover for the GlobalSearchBar to simplify the lucene search called DropdownMenu
  • Added recent search list into the popover
  • Added visual feedback for Search Query validity. (GlobalSearchBar is green for a valid Query and red for invalid query).
  • Pressing buttons in the DropDownMenu adds a new SearchItem to the searchItemList in SearchFieldSynchronizer and synchronizes with the GlobalSearchBar.
  • Added intern textfield in DropDownMenu in order to autocomplete the typed searchstrings. With an add, search and delete button you are able to add the typed string to the GlobalSearchBar, with the search-button you can search your global repository and with the delete button you can delete the whole searchstring .
  • Removed RegexButton.

Recent Prototype looking like this:

image

Current problems:

  • Removed the ChipView prototype as it's not working.
  • Bracket logic (AND^-1/OR^-1) not working properly yet.
  • YearRange Slider input (yearrange:) doesn't search correctly.
  • Recent search also considers invalid search queries.

julianbopp and others added 30 commits November 13, 2021 16:26
@julianbopp
Add ChipView Bar below GlobalSearchBar
3543a15
@julianbopp
Add Suggestion List to ChipView Bar
a9fd464
@josphstar
Fix dropdown menu appearance and add test method to author button
89f9986 
- Fixed odd behaviour where dropdown reapppears when repeatedly clicking search bar
- Removed detachable attrubute (for now?)
- Corrected Checkstyle
- Added test method to author button (dont allow attributes without search terms)
@josphstar
Improve buttons and fix dropdown menu appearance
cd71654 
- Fixed odd behaviour where dropdown reapppears when repeatedly clicking search bar
- Removed detachable attrubute (for now?)
- Corrected Checkstyle
- Buttons dont allow adding attributes when prior ones are empty
@sjHong645
Fix for issue 8198, 8133 (JabRef#8229)
10a2760 
* Update LibraryPropertiesDialogViewModel.java

* Update JabRefPreferences.java

* Update SaveOrderConfig.java

* Update LibraryPropertiesDialogViewModel.java

* Update JabRefPreferences.java

* Update SaveOrderConfig.java
@dmadoery
add buttonEventHandler for DropDownMenu
c6f8066
@koppor
Fix "Library has changed externally" with CRLF markers (JabRef#8239)
c94fa48 
* Add Javadoc to Entrycomparator#compare (and merge - in code to one place)

* Refine duplicate checker

- Compare remaining fields if requried and optional do not differ
- Ignore CRLF at field comparison

* When loading a .bib file, it is opened read only

* Fix checkstyle
@koppor
Fix mixed CRLF / CR (JabRef#8238)
5680d15 
* Remove "% Encoding: UTF8"

* Introduce BibWriter

* Fixes for the results of the block functionality

* The written `.bib` file keeps the newline separator of the loaded `.bib` file

* Fix checkstyle

* Fix architecture test --> BibDatabase uses Sytem directly

* NEWLINE does not need to be altered anymore

* Fix obosolte language key

* Fix checkstyle

* Increase LOOKAHEAD
@antalk2
Oobranch g : add actions (JabRef#7792)
5558408 
* step0 : start model/openoffice, logic/openoffice/style

* correction: import order

* add general utilities

* add UNO utilities, move CreationException, NoDocumentException

* Xlint:unchecked model/openoffice/util

* add ootext

* add rangesort

* add compareStartsUnsafe, compareStartsThenEndsUnsafe

* add Tuple3

* add ootext

* add rangesort

* delNamesArray size correction

* rangeSort update

* cleanup

* style additions

* add backend

* add frontend

* add actions

* checkstyle on tests

* add missing message

* add backend

* add frontend

* add actions

* apply oobranch-[DEFG]-update.patch

* not using RangeSet

* use StringUtil.isNullOrEmpty

* no natural sort for ComparableMark

* in response to review

JabRef#7788 (review)

- more use of StringUtil.isNullOrEmpty
- private final XTextRangeCompare cmp;
- List<V> partition = partitions.computeIfAbsent(partitionKey, _key -> new ArrayList<>());
- visualSort does not throw WrappedTargetException, NoDocumentException
- set renamed to comparableMarks

* use {@code }, PMD suggestions

* update logic/style from improve-reversibility-rebased-03

* update model/style from improve-reversibility-rebased-03

* replaced single-character names in OOBibStyle.java (in changed part)

* some longer names in OOBibStyleGetCitationMarker.java

* drop normalizePageInfos, use 'preferred' and 'fallback' in getAuthorLastSeparatorInTextWithFallBack

* checkstyle

* use putIfAbsent

* use "{}" with LOGGER

* use Objects.hash and Objects.equals in CitationLookupResult

* simplified CitedKey.getBibEntry

* more use of "{}" in LOGGER

* more use of "{}" in LOGGER

* more use of "{}" in LOGGER

* Citation.lookup: use streams

* Citation.lookup: Optional::get before findFirst

* putIfAbsent returns null for new entry

* What is 52 in Backend52

* apply 2021-08-20-a/oobranch-E-update.patch

Brings oobranch-E up to
89b0968 @ origin/improve-reversibility-rebased-03 Merge remote-tracking branch 'upstream/main' into improve-reversibility-rebased-03

* sync to improve-reversibility-rebased-03 cb13256

commit cb13256 (HEAD -> improve-reversibility-rebased-03, origin/improve-reversibility-rebased-03)
Author: Antal K <antalk2@gmail.com>
Date:   Fri Aug 20 11:39:39 2021 +0200

    align dots

* longer name

* follow some PMD suggestions

* apply suggested changes
@koppor @calixtus @Siedlerchr
Make PdfGrobiImporterTest as FetcherTest
a7daa85 
Co-authored-by: Carl Christian Snethlage <50491877+calixtus@users.noreply.github.com>
Co-authored-by: Christoph <siedlerkiller@gmail.com>
@josphstar
Merge pull request #1 from josphstar/DropDownProto_Mark
98c958b 
Improved buttons
@Siedlerchr
New Crowdin updates (JabRef#8240)
e8fc09b 
* New translations JabRef_en.properties (French)

* New translations JabRef_en.properties (Russian)

* New translations JabRef_en.properties (Persian)

* New translations JabRef_en.properties (Indonesian)

* New translations JabRef_en.properties (Portuguese, Brazilian)

* New translations JabRef_en.properties (Vietnamese)

* New translations JabRef_en.properties (Chinese Traditional)

* New translations JabRef_en.properties (Chinese Simplified)

* New translations JabRef_en.properties (Turkish)

* New translations JabRef_en.properties (Swedish)

* New translations JabRef_en.properties (Portuguese)

* New translations JabRef_en.properties (Spanish)

* New translations JabRef_en.properties (Polish)

* New translations JabRef_en.properties (Norwegian)

* New translations JabRef_en.properties (Dutch)

* New translations JabRef_en.properties (Korean)

* New translations JabRef_en.properties (Japanese)

* New translations JabRef_en.properties (Italian)

* New translations JabRef_en.properties (Greek)

* New translations JabRef_en.properties (German)

* New translations JabRef_en.properties (Danish)

* New translations JabRef_en.properties (Tagalog)
@koppor
Fix search: NOT binds more than AND (JabRef#8241)
96a4c0e
@julianbopp
Merge branch 'DropDownMenu_prototype' of github.com:josphstar/jabref …
d44f961 
…into ChipView_prototype
@dependabot
Bump archunit-junit5-api from 0.21.0 to 0.22.0 (JabRef#8252)
980dea4 
Bumps [archunit-junit5-api](https://github.com/TNG/ArchUnit) from 0.21.0 to 0.22.0.
- [Release notes](https://github.com/TNG/ArchUnit/releases)
- [Commits](TNG/ArchUnit@v0.21.0...v0.22.0)

---
updated-dependencies:
- dependency-name: com.tngtech.archunit:archunit-junit5-api
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot
Bump antlr4 from 4.9.2 to 4.9.3 (JabRef#8251)
8a3b77b 
Bumps [antlr4](https://github.com/antlr/antlr4) from 4.9.2 to 4.9.3.
- [Release notes](https://github.com/antlr/antlr4/releases)
- [Changelog](https://github.com/antlr/antlr4/blob/master/CHANGES.txt)
- [Commits](antlr/antlr4@4.9.2...4.9.3)

---
updated-dependencies:
- dependency-name: org.antlr:antlr4
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot
Bump byte-buddy-parent from 1.12.0 to 1.12.1 (JabRef#8249)
6293196 
Bumps [byte-buddy-parent](https://github.com/raphw/byte-buddy) from 1.12.0 to 1.12.1.
- [Release notes](https://github.com/raphw/byte-buddy/releases)
- [Changelog](https://github.com/raphw/byte-buddy/blob/master/release-notes.md)
- [Commits](raphw/byte-buddy@byte-buddy-1.12.0...byte-buddy-1.12.1)

---
updated-dependencies:
- dependency-name: net.bytebuddy:byte-buddy-parent
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot
Bump commons-cli from 1.4 to 1.5.0 (JabRef#8250)
a52a677 
Bumps commons-cli from 1.4 to 1.5.0.

---
updated-dependencies:
- dependency-name: commons-cli:commons-cli
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot
Bump gittools/actions from 0.9.10 to 0.9.11 (JabRef#8248)
9955a33 
Bumps [gittools/actions](https://github.com/gittools/actions) from 0.9.10 to 0.9.11.
- [Release notes](https://github.com/gittools/actions/releases)
- [Commits](GitTools/actions@v0.9.10...v0.9.11)

---
updated-dependencies:
- dependency-name: gittools/actions
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@koppor
Replace styfle/cancel-workflow-action@0.9.1 by GitHub's "concurrency"…
1c463be 
… feature (JabRef#8243)
@koppor @Siedlerchr
[Bot] Update CSL styles (JabRef#8245)
f3bd58a 
* Squashed 'buildres/csl/csl-styles/' changes from 3a6a0a7..0654e16

0654e16 Create scandinavian-journal-of-information-systems.csl (JabRef#5716)
ce2d537 Update journal-of-computer-applications-in-archaeology.csl (JabRef#5715)
755d3d3 Create human-rights-law-review.csl (JabRef#5626)
0feda94 Create journal-of-intercultural-studies.csl (JabRef#5709)
ae4756d Update acta-universitatis-agriculturae-sueciae.csl (JabRef#5713)
323d9ac Update mohr-siebeck-recht.csl (JabRef#5559)
15530a8 Bch corr (JabRef#5712)
094a1af Create forschungsjournal-soziale-bewegungen-fjsb.csl (JabRef#5699)
cb91566 initialize authors and editors (JabRef#5714)
2d5cfff Create cancer-biomarkers.csl (JabRef#5703)
5e264d5 Update multidisciplinary-digital-publishing-institute.csl (JabRef#5708)
46e961f Create klinische-padiatrie.csl (JabRef#5711)
e81e877 Create bulletin-archeologique-des-ecoles-francaises-a-l-etranger.csl (JabRef#5704)
0029c5a Create polar-research.csl 🧊 (JabRef#5702)
7db1361 Update vancouver-imperial-college-london.csl (JabRef#5641)
b953e9f Update iso690-author-date-fr-no-abstract.csl (JabRef#5706)
91eda8c Update thieme-german.csl (JabRef#5710)
ebe0787 Update harvard-imperial-college-london.csl (JabRef#5643)
2d4db76 Fix UNESCO IIEP in text
436cbf4 Create revue-archeologique-de-narbonnaise.csl (JabRef#5688)
5150bcf Create journal-of-computer-assisted-tomography.csl (JabRef#5690)
dd6f050 Create anti-trafficking-review.csl (JabRef#5658)
08e622f Create the-angle-orthodontist.csl (JabRef#5685)
c6a1907 journal-of-palm-oil-research.csl fix several errors (JabRef#5686)
6cbe29d Create bern-university-of-applied-sciences-school-of-agricultural-for… (JabRef#5684)
f590dc1 Update biomed-central.csl (JabRef#5701)
1efce81 Update turabian-author-date.csl (JabRef#5695)
12dbba5 Create tyndale-bulletin (JabRef#5673)
b0746db Create Engineered Regeneration (JabRef#5682)
e38b953 wikipedia citation template (JabRef#5662)
5e7f731 Create early-music-history.csl (JabRef#5679)
86443f3 Create zeitschrift-fur-politik.csl (JabRef#5676)
68f1996 Create annals-of-work-exposures-and-health.csl (JabRef#5666)
1ba9dc6 Create brazilian-journal-of-psychiatry.csl (JabRef#5672)
438f92c fix error for speech in ama styles (JabRef#5693)
7a0c2d3 set initialize-with-hyphen to false (JabRef#5689)
3bd2765 Update emu-austral-ornithology.csl (JabRef#5671)
31492b2 fix various errors in natura-croatica.csl (JabRef#5687)
94d6b23 Update iso690-author-date-cs.csl (JabRef#5677)
5d017da minor update on the "Haute école de gestion de Genève - ISO 690" style (JabRef#5665)
2cad8f6 add ibid/subsequent to comparative-politics.csl (JabRef#5669)
de0b116 Create taylor-and-francis-vancouver-national-library-of-medicine.csl (JabRef#5650)
ed87f99 Update bulletin-de-correspondance-hellenique.csl (JabRef#5663)

git-subtree-dir: buildres/csl/csl-styles
git-subtree-split: 0654e16

* Squashed 'buildres/csl/csl-locales/' changes from 0cc3885f61..d5ee85de8e

d5ee85de8e Period after Übers. added (JabRef#241)

git-subtree-dir: buildres/csl/csl-locales
git-subtree-split: d5ee85de8e74d4109509014758b6f496a968ff03

* fix  merge error

Co-authored-by: github actions <jabrefmail+webfeedback@gmail.com>
Co-authored-by: Siedlerchr <siedlerkiller@gmail.com>
@julianbopp
Queries now get added to RecentSearch when Searchbar loses focus
aff9a10 
Also modified RecentSearch such that empty strings do not get added to
the list.
@julianbopp
Fix Indentation
86f2474
@julianbopp
Remove comment
d6d51fe
@julianbopp
Merge branch 'RecentSearch_prototype_Julian' into ChipView_prototype
fc66433
@julianbopp
First try with SearchFieldSynchronizer
52c12ae
@josphstar
Fix null pointer exception when clicking on empty space in recent sea…
f029581 
…rch list
@josphstar
Fix wrong carret position when using recent search list
71522e6
@josphstar
Add carret position method
59ff03c
@josphstar
Fix checkstyle and clean up
859ac83
julianbopp and others added 19 commits December 11, 2021 23:35
@julianbopp
Add basic bracket logic
abd467a
@dmadoery
yearRangeSlider fixed
0b00ebb
@julianbopp
Change comment
66fa2e8
@julianbopp
Add AND^-1 and OR^-1
aae9f90
@albertjasari
Update Year-Range-Slider in DropDownMenu.java
5c5a0c4
@albertjasari
Merge branch 'Year-Range-Slider' into prototype2.0
6e13711 
# Conflicts:
#	src/main/java/org/jabref/gui/search/DropDownMenu.java
@albertjasari
Merged Year-Range-Slider from Branch: Year-Range_Slider (DropDownMenu…
36edcfd 
….java)
@julianbopp
Merge branch 'DropDownProto_Julian' into prototype2.0
622caae
@julianbopp
Merge branch 'prototype2.0' of github.com:josphstar/jabref into proto…
b3a0f4c 
…type2.0
@dmadoery
updated year_range-slider
a145f56
@julianbopp
Fix RecentSearch
e60d391
@julianbopp
Merge branch 'prototype2.0' of github.com:josphstar/jabref into proto…
0007b36 
…type2.0
@josphstar
Add presentation slides
b27b1a1
@josphstar
Merge branch 'designdoc'
868be84
@josphstar
Merge branch 'testplan'
8fa397e 
# Conflicts:
#	src/main/java/org/jabref/gui/search/DropDownMenu.java
#	src/main/java/org/jabref/gui/search/GlobalSearchBar.java
#	src/main/java/org/jabref/gui/search/SearchFieldSynchronizer.java
#	src/main/java/org/jabref/gui/search/SearchItem.java
@josphstar
Merge branch 'praesentation'
6f52487
@josphstar
Merge branch 'prototype2.0'
564fe70
@josphstar
Merge branch 'prototype2.0'
9bee6df
@josphstar
Add project intern files and update UML diagrams
b09a4fe
@julianbopp julianbopp changed the title Finale Abgabe Finale Abgabe issue#341 Dec 22, 2021
@julianbopp julianbopp changed the title Finale Abgabe issue#341 Implement better search issue#341 Dec 22, 2021
@julianbopp
Copy link
Collaborator Author

Link to JabRef PR: JabRef#8356

We were not able to make a PR to Marcel's repo, because this repo is a fork of the original JabRef repo.

@julianbopp julianbopp closed this Apr 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marcelluethi marcelluethi Awaiting requested review from marcelluethi

@colinhex colinhex Awaiting requested review from colinhex

@emugdan emugdan Awaiting requested review from emugdan

Assignees

@albertjashari albertjashari

@josphstar josphstar

@dmadoery dmadoery

@julianbopp julianbopp

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@julianbopp @albertjashari @josphstar @dmadoery @sjHong645 @koppor @antalk2 @Siedlerchr @albertjasari