Skip to content

Commit

Permalink
Fix nasa#1301, remove option for "osal_compatible"
Browse files Browse the repository at this point in the history
Currently it is assumed/required that resource IDs follow the "osal compatible"
pattern.  Perhaps in a future version this could change, but for now it is
simpler to just require this configuration, rather than having an option
with only one choice.

This renames/moves the header file but the content is not fundamentally changed.
  • Loading branch information
jphickey committed Apr 12, 2021
1 parent e80aae9 commit 85584aa
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 13 deletions.
1 change: 1 addition & 0 deletions modules/resourceid/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@ set(resourceid_SOURCES
add_library(resourceid STATIC ${resourceid_SOURCES})

target_link_libraries(resourceid PRIVATE core_private)
target_include_directories(resourceid PUBLIC fsw/inc)

# Add unit test coverage subdirectory
if(ENABLE_UNIT_TESTS)
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -38,8 +38,8 @@
* OSAL ID structure.
*/

#ifndef CFE_RESOURCEID_OSAL_COMPATIBLE_H
#define CFE_RESOURCEID_OSAL_COMPATIBLE_H
#ifndef CFE_RESOURCEID_BASEVALUE_H
#define CFE_RESOURCEID_BASEVALUE_H

/*
** Include Files
Expand Down Expand Up @@ -74,4 +74,4 @@
*/
#define CFE_RESOURCEID_MAKE_BASE(offset) (CFE_RESOURCEID_MARK | ((offset) << CFE_RESOURCEID_SHIFT))

#endif /* CFE_RESOURCEID_OSAL_COMPATIBLE_H */
#endif /* CFE_RESOURCEID_BASEVALUE_H */
10 changes: 0 additions & 10 deletions modules/resourceid/mission_build.cmake
Original file line number Diff line number Diff line change
Expand Up @@ -20,13 +20,3 @@ generate_config_includefile(
FILE_NAME "cfe_resourceid_typedef.h"
FALLBACK_FILE "${CMAKE_CURRENT_LIST_DIR}/option_inc/${RESOURCEID_HDR_FILE}"
)

# Resource ID base value header
# Currently the "osal compatible" version is the only provided implementation,
# but missions can provide their own if desired to override this.
generate_config_includefile(
FILE_NAME "cfe_resourceid_basevalue.h"
FALLBACK_FILE "${CMAKE_CURRENT_LIST_DIR}/option_inc/cfe_resourceid_osal_compatible.h"
)

include_directories(${CMAKE_CURRENT_LIST_DIR}/inc)

0 comments on commit 85584aa

Please sign in to comment.