Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove cfe_resource_osal_compatible.h option and force use #1301

Closed
skliper opened this issue Apr 12, 2021 · 0 comments · Fixed by #1305 or #1431
Closed

Remove cfe_resource_osal_compatible.h option and force use #1301

skliper opened this issue Apr 12, 2021 · 0 comments · Fixed by #1305 or #1431
Assignees
@jphickey
Labels
build-system CFS-40 enhancement
Milestone
Caelum

Comments

@skliper
Copy link
Contributor

skliper commented Apr 12, 2021

Is your feature request related to a problem? Please describe.
Not really currently an option, could simplify/clarify by forcing it

Describe the solution you'd like
Force use

Describe alternatives you've considered
None

Additional context
From code review #1283, various comments.

Requester Info
Jacob Hageman NASA/GSFC, submitted by @ezpollack
@skliper skliper mentioned this issue Apr 12, 2021
Closed
jphickey added a commit to jphickey/cFE that referenced this issue Apr 12, 2021
@jphickey
Fix nasa#1301, remove option for "osal_compatible"
85584aa 
Currently it is assumed/required that resource IDs follow the "osal compatible"
pattern.  Perhaps in a future version this could change, but for now it is
simpler to just require this configuration, rather than having an option
with only one choice.

This renames/moves the header file but the content is not fundamentally changed.
@jphickey jphickey mentioned this issue Apr 12, 2021
Merged
@skliper skliper added the CFS-40 label Apr 13, 2021
astrogeco added a commit that referenced this issue Apr 28, 2021
@astrogeco
Merge pull request #1305 from jphickey/fix-1301-resourceid-options
6a9e8c9 
Fix #1301, remove option for "osal_compatible"
@astrogeco astrogeco mentioned this issue Apr 28, 2021
Merged
@skliper skliper added this to the 7.0.0 milestone Sep 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jphickey jphickey

Labels
build-system CFS-40 enhancement
Projects
None yet
Milestone
Caelum
3 participants
@jphickey @skliper @astrogeco