Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cmd packing #4

Closed
wants to merge 2 commits into from
Closed

Cmd packing #4

wants to merge 2 commits into from

Conversation

mjmccaskey
Copy link
Contributor

The CFE_SB_EDS_PackOutputMessage function is not sufficient for packing command messages. There is only one step in the packing process which cannot handle EDS objects that have constraints such as command codes. This is sufficient for packing telemetry messages in the TO_LAB app as telemetry message typically don't have constraints and the correct EDS object can be obtained from the call to CFE_MissionLib_GetArgumentType.

Additions:
Mirroring the two step unpacking process in CFE_SB_EDS_UnpackInputMessage, there is now a two step packing process to handle if any constraints are found.

Deletions:
The first part of the function that created an EdsId from a base command or telemetry packet was unnecessary. With the input packet header the appropriate starting point for the EdsId is found via CFE_MissionLib_GetArgumentType which overwrites the EdsId set at the beginning.

I've tested this function using both TO_LAB and an EDS version of the Data Storage App. The former is able to pack telemetry messages and the latter is able to pack both telemetry and command messages and write them to a file.

jphickey added a commit that referenced this pull request Oct 1, 2021
Fix #4, incorrect cmdcode macro values
@jphickey jphickey closed this in 3b0b365 Oct 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant