Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Table verification bug fixes. #5

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

mjmccaskey
Copy link
Contributor

There were two bugs related to table verification via CRC in EdsLib

  • The CRC lookup tables were not being initialized, so any CRC calculation would result in 0 regardless of the input table
  • Despite the CRC calculation always giving 0, the table verification would still return with a success.

The fixes for both bugs are as follows.

  • The CRC lookup tables are initialized with a call to EdsLib_Initialize. I put the call within the CFE_SB_EarliyInit function. If there is a better place for this call feel free to change.
  • The return status from the table verification is now saved so if the CRC check fails it will get passed back to the parent function.

With both of these fixes in place I've been able to successfully read in table that have a CRC check.

jphickey added a commit that referenced this pull request Oct 1, 2021
Fix #4, incorrect cmdcode macro values
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant