BREAKING: Use internal fork of make-dir for mkdirs implementation #756
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RyanZim
force-pushed
the
ryan/make-dir
branch
from
89cc8cf to
64a3e2b
Compare
manidlou
reviewed
Feb 7, 2020
brodycj
reviewed
Feb 13, 2020
There was a problem hiding this comment.
I would strongly favor keeping the fork of the mkdirs implementation in its own package somewhere. It should be possible to swap this kind of implementation without too much extra junk in the git history.
I did discover an existing mkdirs package that has not been updated for 5 years or so. Maybe time for someone to update or renew it?
|
@brodybits Our previous code was a fork of an old version of https://www.npmjs.com/package/mkdirp. That package is well-maintained, our fork is much less-so. |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Resolves #619 Everything should work similarly to how it did before; except that we no longer return a file path on success (to match fs.mkdir). Also, errors may be different.
- Error codes are different - Match fs.mkdir behavior on Windows when creating root
RyanZim
force-pushed
the
ryan/make-dir
branch
from
64a3e2b to
29b55cb
Compare
|
Rebased and added new commits fixing issues above. |
|
@jprichardson @manidlou @JPeer264 Ready for final review |
manidlou
approved these changes
Feb 18, 2020
78 tasks
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #619
Everything should work similarly to how it did before; except that we no longer return a file path on success (to match fs.mkdir). Also, errors may be differentBreaking Changes:
fs.mkdir)fs.mkdir)https://github.com/sindresorhus/make-dir