Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Throw original error if stat fails; to match sync implementation #24

Merged
merged 1 commit into from
Feb 12, 2020
Merged

Throw original error if stat fails; to match sync implementation #24

merged 1 commit into from
Feb 12, 2020

Conversation

RyanZim
Copy link
Contributor

@RyanZim RyanZim commented Feb 12, 2020

Fixes #23

@sindresorhus sindresorhus merged commit 25231fe into sindresorhus:master Feb 12, 2020
@sindresorhus
Copy link
Owner

Thanks :)

@RyanZim RyanZim deleted the async-stat-error branch February 12, 2020 21:00
RyanZim added a commit to jprichardson/node-fs-extra that referenced this pull request Feb 14, 2020
@RyanZim
Port sindresorhus/make-dir#24
51938c2
RyanZim added a commit to jprichardson/node-fs-extra that referenced this pull request Feb 18, 2020
@RyanZim
BREAKING: Use internal fork of make-dir for mkdirs implementation (#756)
ab92b24 
* BREAKING: Use internal fork of make-dir for mkdirs implementation

Resolves #619

Everything should work similarly to how it did before; except that
we no longer return a file path on success (to match fs.mkdir).
Also, errors may be different.

* Hopefully fix Windows tests

- Error codes are different
- Match fs.mkdir behavior on Windows when creating root

* Port sindresorhus/make-dir#24

* Add comment for clarity

* Use at-least-node for version sniffing

* Consistent error codes across OSes

* Allow different error codes on different Node versions
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Inconsistency between async and sync implementations
2 participants
@RyanZim @sindresorhus