Correct beginning of inline code position #116
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
There is no error with this patch.
|
markdown-regex-code starts with "\(?:\`\|[^\]\)\(\(`+\)...". If cursor is beginning of buffer, "(match-beginning 0)" is on backtick. While cursor is not beginning of buffer, "(match-beginning 0)" is not on backtick and previous point of backtick. --- foo:bar --- `x` In above example, "(match-beginning 0)" is point of after "---". That point is a code block and "(markdown-code-block-at-pos pos)" returns non-nil, this causes infinite loop of markdown-match-inline-generic. "(match-beginning 1)" of markdown-regex-code always on backtick. We should use "(match-beginning 1)" instead of "(match-beginning 0)" in such case.
syohex
force-pushed
the
infinite-loop-issue
branch
from
4dbf87d
to
aea5120
Compare
|
Thanks--nice catch! Merged with one minor docstring edit (metadata block, not code block). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
markdown-regex-code starts with **"(?:`\|[^\\]\)\(\(
+\)..."**. If cursor is beginning of buffer,(match-beginning 0)is on backtick. While cursor is not beginning of buffer,(match-beginning 0)` is not on backtick and previous point of backtick.In above example,
(match-beginning 0)is point of after '---'. That point is a code block and '(markdown-code-block-at-pos pos)' returns non-nil, this causes infinite loop of markdown-match-inline-generic.(match-beginning 1)of markdown-regex-code always on backtick. We should use(match-beginning 1)instead of '(match-beginning 0') in such case.This is related to #115.
CC: @dabrahams