Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correct beginning of inline code position #116

Closed
wants to merge 2 commits into from
Closed

Correct beginning of inline code position #116

wants to merge 2 commits into from

Commits on Mar 11, 2016

  1. Correct beginning of inline code position 

    markdown-regex-code starts with "\(?:\`\|[^\]\)\(\(`+\)...". If cursor is
beginning of buffer, "(match-beginning 0)" is on backtick. While cursor is not
beginning of buffer, "(match-beginning 0)" is not on backtick and previous point
of backtick.

---
foo:bar
---
`x`

In above example, "(match-beginning 0)" is point of after "---". That point is
a code block and "(markdown-code-block-at-pos pos)" returns non-nil,
this causes infinite loop of markdown-match-inline-generic.
"(match-beginning 1)" of markdown-regex-code always on backtick. We should
use "(match-beginning 1)" instead of "(match-beginning 0)" in such case.
    @syohex
    syohex committed Mar 11, 2016
    Configuration menu
    Copy the full SHA
    aea5120 View commit details
    Browse the repository at this point in the history

  2. Add regression test of #115

    @syohex
    syohex committed Mar 11, 2016
    Configuration menu
    Copy the full SHA
    3f3c42c View commit details
    Browse the repository at this point in the history