Allow combinations of --change-time, --delete, and --edit while correctly counting the number of entries affected

[wren]

cc:

• Fix for #1639 journal overwrite #1640
• Adding an entry with a combination of flags causes a journal overwrite #1639

Related issues:

• Fixes Combinations of --change-time, --delete, and --edit don't work consistently #1696
• Fixes jrnl doesn't display count of entries deleted after deleting entries with --delete #1666
• Fixes Adding an entry with a combination of flags causes a journal overwrite #1639
• Fixes jrnl crashes when adding tag argument after --change-time #1644

Todo

• Add tests
• Merge in develop branch

Checklist

• I have read the contributing doc.
• I have included a link to the relevant issue number.
• I have checked to ensure there aren't other open pull requests
  for the same issue.
• I have written new tests for these changes, as needed.

[micahellison]

This might fix #1666. We'll need to add a test.

[micahellison]

We'll need to add some tests for:

• combinations of action arguments (edit, change-time, delete)
• combinations of stderr output messaging (entries found, entries modified)
• might need some tests for 0 vs 1 vs multiple entries found and/or modified
• unit tests for the new private controller functions

We'll need to come up with a better name for this PR too. It changes some messaging behavior and we'll want that reflected in the changelog.

[micahellison]

I noticed some problems with incorrect count messages while testing this out today, so I added some failing tests for those issues.

[micahellison]

This is green but not finished. We still need to add the tests I mentioned in my comment last week.

We also changed the messaging for when you delete all entries in the editor. Instead of the No entry to save, because no text was received message, we're showing this warning:

┏━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━┓
┃  No text received from editor. Were you trying to delete all the entries?  ┃
┃                                                                            ┃
┃  This seems a bit drastic, so the operation was cancelled.                 ┃
┃                                                                            ┃
┃  To delete all entries, use the --delete option.                           ┃
┗━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━┛

[micahellison]

I added some failing tests that we should look at. I'm not 100% certain what the added/found/deleted counts should be with certain combinations of actions, but I still think they are wrong now in certain situations.

[micahellison]

I finally decided to just keep a register of deleted and added entries in the Journal class. We're already tracking modified entries in its member class Entry so this is not a significant deviation, and now the counts reflect exactly what jrnl did to the journal, even when combining all three actions (change-time, delete, and edit).

This change also has a nice side effect of moving all counting logic outside of the controller class, which has no business doing that anyway. In the long run, I'd like to separate this logic from the data representation of the journal, but I think that's outside of the scope of this PR.

[micahellison]

I still want to add more tests to this. The combination tests are a good start, but I want to test them with search criteria as well.