Encapsulate fields of Region #58
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There are optimizations we could make here if the beg and end fields were encapsulated that are impossible with them public. The other fields should just be encapsulated as good practice.
headius
force-pushed
the
encapsulate_region
branch
from
4dac58e to
ad492d4
Compare
headius
added a commit
to headius/joni
that referenced
this pull request
Feb 4, 2023
This is a follow-up to jruby#58 and will release in 2.2.
This was referenced Feb 4, 2023
headius
added a commit
to headius/joni
that referenced
this pull request
May 23, 2023
This is a follow-up to jruby#58 and will release in 2.2.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are optimizations we could make here if the beg and end fields were encapsulated that are impossible with them public. The other fields should just be encapsulated as good practice.
We will do one release with these fields still public but deprecated, and then a larger version bump when we make them private.