Make Region fields private #59
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a follow-up to jruby#58 and will release in 2.2.
Whie benchmarking the CSV library in JRuby, one of the largest groups of allocated objects was int[] primarily for Region objects, some of which most likely only have one regionand do not need the flexibility of an array of regions. This commit splits Region into multi and single forms, so that single-region objects can be as compact as possible and not require a second (or third) object for the beg/end arrays.
headius
force-pushed
the
private_region_fields
branch
from
db0aa3a to
44204ac
Compare
It's equivalent to begEnd.length / 2.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow-up to #58 and will release in 2.2.