Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[rostwitter] set_aborted when error in tweet_image_server.py #277

Merged
merged 1 commit into from
Sep 8, 2021
Merged

[rostwitter] set_aborted when error in tweet_image_server.py #277

merged 1 commit into from
Sep 8, 2021

Conversation

knorth55
Copy link
Member

@knorth55 knorth55 commented Aug 7, 2021

this PR correctly set actionlib status when error occurs.

708yamaguchi
708yamaguchi approved these changes Aug 8, 2021
View reviewed changes
Copy link
Member

@708yamaguchi 708yamaguchi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Setting actionlib status is important and this PR seems good to me.

I think this PR can be merged if there is no problem with fetch and PR2 for some time.

This was referenced Aug 24, 2021
Closed
Closed
@k-okada k-okada merged commit 674bb1b into jsk-ros-pkg:master Sep 8, 2021
@knorth55 knorth55 deleted the tweet-set-aborted branch September 8, 2021 04:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@708yamaguchi 708yamaguchi 708yamaguchi approved these changes

Assignees
No one assigned
Labels
enhancement rostwitter
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@knorth55 @708yamaguchi @k-okada