-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[dialogflow_task_executive] support launch_args of app_manager #292
Open
sktometometo
wants to merge
7
commits into
jsk-ros-pkg:master
Choose a base branch
from
sktometometo:PR/support-app-manager-launch-args-dialogflow-task-executive
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
[dialogflow_task_executive] support launch_args of app_manager #292
sktometometo
wants to merge
7
commits into
jsk-ros-pkg:master
from
sktometometo:PR/support-app-manager-launch-args-dialogflow-task-executive
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k-okada
added
the
hacktoberfest-accepted
https://hacktoberfest.digitalocean.com/hacktoberfest-update
label
Oct 21, 2021
knorth55
requested changes
Oct 23, 2021
Co-authored-by: Shingo Kitagawa <knorth55@users.noreply.github.com>
Co-authored-by: Shingo Kitagawa <knorth55@users.noreply.github.com>
Co-authored-by: Shingo Kitagawa <knorth55@users.noreply.github.com>
Co-authored-by: Shingo Kitagawa <knorth55@users.noreply.github.com>
knorth55
approved these changes
Oct 25, 2021
This was referenced Sep 30, 2022
…low-task-executive
…low-task-executive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
dialogflow_task_executive
hacktoberfest-accepted
https://hacktoberfest.digitalocean.com/hacktoberfest-update
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support launch_args of app_manager in task_executive.
Result of Example app and agent will be changed according to questions with this PR.
NoticeUntil app_manager is updated to remove launch_args whch are not in app xml automatically, this PR breaks the refrigerator demo.