Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Google Chat ROS #323

Closed
wants to merge 0 commits into from
Closed

Google Chat ROS #323

wants to merge 0 commits into from

Conversation

mqcmd196
Copy link
Member

@mqcmd196 mqcmd196 commented Jan 19, 2022 •
edited
Loading

Moved from #290 and covered all functions of Google Chat API.

@mqcmd196 mqcmd196 mentioned this pull request May 3, 2022
Closed
1 task
@mqcmd196 mqcmd196 force-pushed the google_chat_ros branch 3 times, most recently from cd15c99 to 268adda Compare May 3, 2022 05:30
@mqcmd196 mqcmd196 changed the title [WIP]Google Chat ROS Google Chat for ROS May 3, 2022
@mqcmd196 mqcmd196 marked this pull request as ready for review May 3, 2022 06:07
@mqcmd196 mqcmd196 requested review from iory and knorth55 May 3, 2022 06:07
@mqcmd196 mqcmd196 mentioned this pull request May 3, 2022
Merged
@mqcmd196
Copy link
Member Author

mqcmd196 commented May 3, 2022 •
edited
Loading

Waiting for ros/rosdistro#33017 being merged
Not required, using catkin_virtualenv

@mqcmd196 mqcmd196 changed the title Google Chat for ROS Google Chat ROS May 17, 2022
@mqcmd196 mqcmd196 force-pushed the google_chat_ros branch 2 times, most recently from 4915ba5 to 6fe77aa Compare May 17, 2022 02:37
@knorth55 knorth55 mentioned this pull request May 27, 2022
Closed
14 tasks
@mqcmd196 mqcmd196 force-pushed the google_chat_ros branch 3 times, most recently from 64b79ef to 2b94f98 Compare June 9, 2022 10:01
@mqcmd196 mqcmd196 mentioned this pull request Jun 16, 2022
Merged
@mqcmd196 mqcmd196 force-pushed the google_chat_ros branch 2 times, most recently from dff498d to cc898c7 Compare June 28, 2022 01:13
@knorth55
Copy link
Member

knorth55 commented Aug 2, 2022

please check CI test results.

Compiling ./google_chat_ros/scripts/google_chat_ros_node.py ...
  File "./google_chat_ros/scripts/google_chat_ros_node.py", line 163
    def event_cb(self, event: dict, publish_topic=True):
                            ^
SyntaxError: invalid syntax

@knorth55
Copy link
Member

please resolve the conflict.

@knorth55
Copy link
Member

and can you tell me when I should review this PR?

@mqcmd196
Copy link
Member Author

please check CI test results.

Compiling ./google_chat_ros/scripts/google_chat_ros_node.py ...
File "./google_chat_ros/scripts/google_chat_ros_node.py", line 163
def event_cb(self, event: dict, publish_topic=True):
^
SyntaxError: invalid syntax

Sorry, I removed type-hinting

@mqcmd196
Copy link
Member Author

Sorry for being late. I'll request review when the test goes fine

@mqcmd196 mqcmd196 force-pushed the google_chat_ros branch 3 times, most recently from 4787124 to 136a37b Compare August 31, 2022 04:34
This was referenced Sep 30, 2022
Closed
Open
@knorth55 knorth55 mentioned this pull request Oct 20, 2022
Merged
@k-okada k-okada mentioned this pull request Nov 2, 2022
Closed
@mqcmd196 mqcmd196 closed this Nov 12, 2022
@mqcmd196 mqcmd196 deleted the google_chat_ros branch November 12, 2022 05:51
@k-okada
Copy link
Member

k-okada commented Nov 12, 2022

#392 fixed test and merged. @mqcmd196 if you have more changes, pleae create new PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@knorth55 knorth55 knorth55 approved these changes

@iory iory Awaiting requested review from iory

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mqcmd196 @knorth55 @k-okada