-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[respeaker_ros] Add publish_multichannel option for publishing multi channel audio #350
base: master
Are you sure you want to change the base?
Conversation
Thank you for your update! I think it is desirable to use this feature on real robot (e.g. Fetch) before merging. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think so, too. We have to confirm that this node works well on real robots before merging.
Anyway, that's a wonderful node. I hope this node to solve the problem around voice recognition. e.g: We have to speak voice commands extremely near the robot.
Removed This change does not affect those who were originally using it on channel 1 because |
Thanks. This PR has many good features, so I would appreciate it
|
@708yamaguchi
I added the commits to reflect your comments.
This PR is for multichannel output. For you, I wrote the document, 92477a5 8caae81 383670f |
Thank you for your quick update! In addition, please check the behavior of Then, please check multi channel version. |
Thank you. |
I am very sorry, but I had tested this pull request in fetch, but not in pr2. At least this PR is working well with fetch, so I will look at PR2 for a few days and if it looks OK, I will approve it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR2 has not output any respeaker-related errors for the past three days.
I check that /audio
and /speech_to_text
seems good.
Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please proved linke to demo that requres multichannel audio
What is this?
This PR adds features publishing
~audio_raw
and~speech_audio_raw
for publishing multi-channel audio.Along with that, there is a change to publish
audio_common_msgs/AudioInfo
.This change does not affect those who were originally using it on channel 1 because
~audio
output does not change.