Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve fetch's move base by fetchrobotics's default params #1456

Merged
merged 9 commits into from
May 24, 2022

Conversation

708yamaguchi
Copy link
Member

@708yamaguchi 708yamaguchi commented Apr 20, 2022

Please merge after #1455

This PR includes knorth55#124, knorth55#125 and knorth55#126

We thought TebLocalPlanner is the best for fetch15 and fetch1075, so we created #1455.

However, we found that the fetchrobtics's default parameter is better for fetch1075.

In this PR, we use the original paramter for fetch15 and use the default parameter for fetch1075.

We tested the parameter with go-to-kitchen demo.

@sktometometo
Copy link
Contributor

sktometometo commented Apr 20, 2022

@708yamaguchi relayして出している /move_base/navigation_plan_viz/move_base/global_plan_viz は分離する意味が無い気がします。

@k-okada
Copy link
Member

k-okada commented Apr 21, 2022

However, we found that the fetchrobtics's default parameter is better for fetch1075. That's good lesson! That's always good to imagine what is the fetchrobotics's engineer's job and how should we cooperate with them.

@708yamaguchi
Copy link
Member Author

I rebased origin/master to resolve conflicts.

I will add some commits to reflect the review #1456 (comment)

@k-okada k-okada merged commit 4ff519b into jsk-ros-pkg:master May 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants