Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add supervisor job for edgetpu-panorama recognition #1465

Open
wants to merge 11 commits into
base: master
Choose a base branch
from

Conversation

708yamaguchi
Copy link
Member

@708yamaguchi 708yamaguchi commented Apr 20, 2022

@k-okada
Copy link
Member

k-okada commented Apr 21, 2022

@knorth55
Copy link
Member

Should we switch from supervisor to systemd?
If so, we will work on it.

@k-okada
Copy link
Member

k-okada commented Apr 21, 2022

please discuss with @708yamaguchi @sktometometo ,
Since auto starting function is so necessary and useful, I think it is time to establish common tools/method to put them in our robots,

My comment is

  1. Sometimes it is better to investigate different ideas, like tendon robot vs geared robot, lider vs vision, but I think we have no reason to keep systemd vs supervisor
  2. Since systemd/supervisor is a robot agnostic tool, we could put the main code in jsk_robot_comon, like start roscore, app_manager, ...
  3. It always nice to imagine someone is doing same thing, I haven't use https://github.com/magazino/systemd_ros by myself, but I think they use this on their product and they always have talented engineers, so there are good reason to try them.

BTW, What system does Stratch use ?

@knorth55
Copy link
Member

knorth55 commented Apr 21, 2022

IMO, systemd might be better with Cockpit than supervisor, but the motivation is just for the cool GUI.
So I'm not super excited to switch from supervisor to systemd.
(Also I don't trust systemd, it will change soon as init.d, service, upstart...)

Since systemd/supervisor is a robot agnostic tool, we could put the main code in jsk_robot_comon, like start roscore, app_manager, ...

This idea sounds good, but I don't have a good idea.
Because JSK robots are targeted to start all nodes with one or two launch, systemd config may be just one or two, so we can write down manually.
Other non-ROS services can be the same for all robots, so I can make the jsk_robot_common/jsk_robot_systemd, but I'm not so motivated...

It always nice to imagine someone is doing same thing, I haven't use https://github.com/magazino/systemd_ros by myself, but I think they use this on their product and they always have talented engineers, so there are good reason to try them.

I know systemd_ros, but hmmm.
If all robots use systemd and generate the systemd conf in jsk_robot, that would be great.
But the reason why I'm not motivated is that systemd cannot be on PR2 + Indigo.
We can make the system for Fetch and Spot, but Spot systemd is well-handcrafted and super complicated...

@knorth55
Copy link
Member

Stretch uses default Startup Applications in Ubuntu.
https://help.ubuntu.com/stable/ubuntu-help/startup-applications.html.en

@k-okada
Copy link
Member

k-okada commented Apr 21, 2022

Because JSK robots are targeted to start all nodes with one or two launch, systemd config may be just one or two, so we can write down manually.

That's good point, I also prefer using jsk__startup.launch for systemd/supervisor, and if we do so, I think using different system for different robot may not a big problem.
For example, this PR essentially add one node to one launch file, but require to update 7 files and ask other people to review.

But, If we need to run each functions with different terminal using tmux, then we need smart way to keep our configuration and develop process more simple.

Stretch uses default Startup Applications in Ubuntu.

They are smart, as always...

@sktometometo
Copy link
Contributor

@708yamaguchi Could you resolve conflicts?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants