Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[jsk_fetch_startup] Use audible_warning to speak diagnostics #1480

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

708yamaguchi
Copy link
Member

@708yamaguchi 708yamaguchi commented May 13, 2022

Duplicate knorth55#223

I use jsk_tools/audible_warning.py instead of jsk_fetch_startup/warning.py's function of speaking diagnostic.
jsk-ros-pkg/jsk_common#1607

I think it is important to unify the function of speaking diagnostic.

@k-okada
Copy link
Member

k-okada commented May 24, 2022

need to fix CI of jsk-ros-pkg/jsk_common#1607

@k-okada k-okada added this to the Fetch 2022/05 milestone May 24, 2022
@708yamaguchi 708yamaguchi force-pushed the use-audible-warning-master branch from 5887098 to f88e7b3 Compare May 25, 2022 02:39
@708yamaguchi
Copy link
Member Author

@708yamaguchi
Copy link
Member Author

I think we do not need to wait for upstream release.
The reason is the same as #1481 (comment)

===
In fetch PC, we use knorth55/jsk_common's fetch15 branch.

- git:
local-name: jsk-ros-pkg/jsk_common
uri: https://github.com/knorth55/jsk_common.git
version: fetch15

In this branch, sanity_diagnostics.py is already merged.
knorth55/jsk_common#4

@708yamaguchi 708yamaguchi force-pushed the use-audible-warning-master branch from f88e7b3 to 5db8763 Compare July 4, 2022 20:36
@708yamaguchi
Copy link
Member Author

I force-pushed the commits to resolve conflicts.

@708yamaguchi
Copy link
Member Author

The latest commit f47f29d is cherry-picked from knorth55#282

rosrun rosserial_python seiral_node.py via bluetooth sometimes loses connection.
At that time, serial_node.py generates a diagnostics error as follows.
ignore_rosserial_error

However, serial_node.py can automatically reconnect after losing connection.
So I think audible_warning should ignore this diagnostics error.

@k-okada
Copy link
Member

k-okada commented Sep 8, 2022

wait for discussion #1562 (comment)

@sktometometo
Copy link
Contributor

@708yamaguchi Could you please resolve conflicts?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants