Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[jsk_fetch_startup] Ignore rosserial audible warning because it automatically reconnects #282

Merged

Conversation

708yamaguchi
Copy link
Collaborator

@708yamaguchi 708yamaguchi commented Jul 4, 2022

rosrun rosserial_python seiral_node.py via bluetooth sometimes loses connection.
At that time, serial_node.py generates a diagnostics error as follows.
ignore_rosserial_error

However, serial_node.py can automatically reconnect after losing connection.
So I think audible_warning should ignore this diagnostics error.

@708yamaguchi
Copy link
Collaborator Author

@iory
Could you check my code style of warning_blacklist.yaml?

As far as I have observed, fetch1075 no longer speaks rosserial errors.

@iory
Copy link
Collaborator

iory commented Jul 5, 2022

Could you check my code style of warning_blacklist.yaml?

There is no problem. LGTM.

@knorth55 knorth55 merged commit 06e3093 into knorth55:fetch15 Jul 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants