[jsk_fetch_startup] Send kitchen demo mail and twitter with smach_to_mail.py #1568
Conversation
tkmtnt7000
changed the title
tkmtnt7000
force-pushed
the
PR-smach-mail-kitchen-demo
branch
from
6fa24a2 to
26346d4
Compare
| "inspect-kitchen" | ||
| (let () | ||
| (inspect-kitchen :tweet (cdr (assoc 'tweet args))) | ||
| (set-alist 'description "キッチンの様子を見たよ" args) |
There was a problem hiding this comment.
as I comment on jsk-ros-pkg/jsk_roseus#716 (comment), DESCRIPTION is the message from robot to users to tell how they thik and what they do. so
(let ((label-names (inspect-kitchen ....))
(set-alist 'description (format nil "キッチンの様子を見たよ。~Aがあったよ" label-names) args)
(defun notify-recognition (&key (location "kitchen"))
...
label-names)
...
There was a problem hiding this comment.
Thank you very much for advice.
I add notify-text in description and write like this. ba5fc8f
キッチンの様子を見たよ．cupがあったよ
[ IMAGE ]
There was a problem hiding this comment.
Like this, this is tracshcan example, though.
| (let* ((n-trial (cdr (assoc 'n-kitchen-trial args))) | ||
| (success (move-to-sink-front :n-trial n-trial))) | ||
| (setf (cdr (assoc 'success-go-to-kitchen args)) success) | ||
| (set-alist 'description "キッチンに向かったよ" argw) |
There was a problem hiding this comment.
If we can undeerstand DESCRIPTION as transition (arrow) of smach state, can we write DESCRIPTION based on the exit status of each node ? instead of https://github.com/jsk-ros-pkg/jsk_robot/pull/1568/files#diff-db470e8365f9cf73b75d39c7822ddc1513068c80cf3e12dd4a3127cba08d2863R684-R687 ???
(if succcess
(set-alist 'description "キッチンに向かったよ" argw)
(set-alist 'description "キッチンに向かったけど，迷子になっちゃった" argw)
)
There was a problem hiding this comment.
Yes.
I use exit status of each node in 1213188
| "get-light-on-state" | ||
| (let ((light-on (get-light-on))) | ||
| (set-alist 'initial-light-on light-on args) | ||
| (set-alist 'description "電気がついているか確認したよ" args) |
There was a problem hiding this comment.
we do not have to set DESCRIPTOIN/IMAGE for all states, if it is redundant
If we get messages as follows, may be we can remove "電気がついているか確認したよ" descprion and IMAGE
電気がついているか確認したよ
[IMAGE-BRIGHT]
電気がついていたよ
[IMAGE-BRIGHT]
キッチンをみにいくよ
[IMAGE-DARK]
電気がついているか確認したよ
[IMAGE-DARK]
電気をつけたよ
[IMAGE-BRIGHT]
There was a problem hiding this comment.
I remove "電気がついているか確認したよ" and check if room light is on by get-light-on status.1213188
tkmtnt7000
force-pushed
the
PR-smach-mail-kitchen-demo
branch
from
4622bc8 to
1213188
Compare
tkmtnt7000
force-pushed
the
PR-smach-mail-kitchen-demo
branch
from
7054a72 to
9726fc9
Compare
tkmtnt7000
changed the title
|
@tkmtnt7000 sorry could you resolve conflicts or create new PR that only update |
tkmtnt7000
force-pushed
the
PR-smach-mail-kitchen-demo
branch
from
9726fc9 to
c069170
Compare
tkmtnt7000
force-pushed
the
PR-smach-mail-kitchen-demo
branch
from
c069170 to
3cfab64
Compare
|
I rebased current master branch to resolve conflicts. |
| @@ -265,6 +265,13 @@ | |||
| </rosparam> | |||
| </node> | |||
|
|
|||
| <!-- send email, twitter with smach --> | |||
| <node name="server_name" pkg="jsk_robot_startup" type="smach_to_mail.py" output="screen"> | |||
There was a problem hiding this comment.
smach topic name is normally /server_name/smach/container_status.
thats why smach_to_mail node's name is server_name in launch
but I think it is confusing and a bit lazy solution...
From jsk-ros-pkg/jsk_3rdparty#375 (comment)
This PR enables us to send kitchen demo mail with embed image and description by using
smach_to_mail.py.And this can send tweet automatically, too.jsk-ros-pkg/jsk_3rdparty#375
smach-kitchen-20220822.mp4
======
This PR contains knorth55#327, knorth55#326, knorth55#311, knorth55#312.
And also this PR contains and partically depends on obinata-san changes (the place to patrol and take photos) 8ea2c32, dff17cf, 6d5475f, acf1026, so please feel free to revise and send another PR to jsk-ros-pkg. cc:@mqcmd196