Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Erase flash #3

Merged
merged 3 commits into from
Aug 22, 2023
Merged

Erase flash #3

merged 3 commits into from
Aug 22, 2023

Conversation

jnross
Copy link

@jnross jnross commented Aug 22, 2023

No description provided.

@nathan-whittington
Copy link

This brings in the erase-parts subcommand. Is that command available upstream?

Copy link

@nathan-whittington nathan-whittington left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and I verified it erased my board.

@jnross
Copy link
Author

jnross commented Aug 22, 2023

This brings in the erase-parts subcommand. Is that command available upstream?

Not yet, but I have a PR in to upstream it. We're leading the charge here. This uses the long-established EraseRegion command, and figure out the offset and size of the region to erase from the partition table. It's basically a convenience command. I probably should add the erase_region subcommand too, for parity with esptool.py.

@jnross jnross merged commit 907a6e4 into main Aug 22, 2023
jnross added a commit that referenced this pull request Aug 22, 2023
* Add command to erase flash. (For esp-rs#460)

* Add `erase-parts` command to erase named partitions.

* Fix timeout logic when erasing regions.
@jnross jnross deleted the erase-flash branch August 22, 2023 20:04
jnross added a commit that referenced this pull request Aug 22, 2023
* Add command to erase flash. (For esp-rs#460)

* Add `erase-parts` command to erase named partitions.

* Fix timeout logic when erasing regions.
@jnross jnross restored the erase-flash branch August 24, 2023 18:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants