Repeated @ExtendWith meta-annotations on fields no longer supported in 5.11.x

[ppkarwasz]

Since version 5.11.x, if a field is meta-annotated with multiple @ExtendWith annotations, JUnit fails to detect them.

The problem seems to be in ExtensionUtils#streamExtensionFilteringFields, which does not take into account repeatable annotations:

junit5/junit-jupiter-engine/src/main/java/org/junit/jupiter/engine/descriptor/ExtensionUtils.java

Lines 204 to 209 in 8e9094d

	private static Stream<Field> streamExtensionRegisteringFields(Class<?> clazz, Predicate<Field> predicate) {
	Predicate<Field> composedPredicate = predicate.and(
	field -> isAnnotated(field, ExtendWith.class) || isAnnotated(field, RegisterExtension.class));
	return streamFields(clazz, composedPredicate, TOP_DOWN)//
	.sorted(orderComparator);
	}

Steps to reproduce

1. Meta-annotate some test class fields with multiple @ExtendWith annotations:

   @Retention(RetentionPolicy.RUNTIME)
   @ExtendWith(Extension1.class)
   @ExtendWith(Extension2.class)
   public @interface ComposedAnnotation {}

   public class TestClassWithFields {
   
     @ComposedAnnotation
     private static int staticFieldMetaAnnotatedTwice;
   
     @ComposedAnnotation
     private int instanceFieldMetaAnnotatedTwice;
   }

2. Run the following test cases:

   class ExtensionsUtilsTests {
     @Test
     void discoverExtensionsOnStaticFields() {
       ExtensionRegistrar registrar = mock();
       ExtensionUtils.registerExtensionsFromStaticFields(registrar, ClassWithFields.class);
       verify(registrar).registerExtension(Extension1.class);
       verify(registrar).registerExtension(Extension2.class);
     }
     @Test
     void discoverExtensionsOnInstanceFields() {
       ExtensionRegistrar registrar = mock();
       ExtensionUtils.registerExtensionsFromInstanceFields(registrar, ClassWithFields.class);
       verify(registrar).registerExtension(Extension1.class);
       verify(registrar).registerExtension(Extension2.class);
     }
   }

Context

• Used versions (Jupiter/Vintage/Platform): Jupiter 5.11.1 / Platform 1.11.1
• Build Tool/IDE: Maven

[sbrannen]

Good catch, @ppkarwasz! 👍

The problem seems to be in ExtensionUtils#streamExtensionFilteringFields, which does not take into account repeatable annotations:

Indeed, the switch to the use of isAnnotated() there seems to be the culprit.

We'll work on a fix.

Cheers,

Sam

[marcphilipp]

This was introduced in #3895

[sbrannen]

I've reproduced this in the following standalone test class, based on the examples from @ppkarwasz.

package org.junit.jupiter.engine.descriptor;

import static org.mockito.Mockito.mock;
import static org.mockito.Mockito.verify;

import java.lang.annotation.Retention;
import java.lang.annotation.RetentionPolicy;

import org.junit.jupiter.api.Test;
import org.junit.jupiter.api.extension.ExtendWith;
import org.junit.jupiter.api.extension.Extension;
import org.junit.jupiter.engine.extension.ExtensionRegistrar;

class ExtensionsUtilsTests {

	@Test
	void discoverExtensionsOnStaticFields() {
		ExtensionRegistrar registrar = mock();
		ExtensionUtils.registerExtensionsFromStaticFields(registrar, TestClassWithFields.class);
		verify(registrar).registerExtension(Extension1.class);
		verify(registrar).registerExtension(Extension2.class);
	}

	@Test
	void discoverExtensionsOnInstanceFields() {
		ExtensionRegistrar registrar = mock();
		ExtensionUtils.registerExtensionsFromInstanceFields(registrar, TestClassWithFields.class);
		verify(registrar).registerExtension(Extension1.class);
		verify(registrar).registerExtension(Extension2.class);
	}

	static class Extension1 implements Extension {
	}

	static class Extension2 implements Extension {
	}

	@Retention(RetentionPolicy.RUNTIME)
	@ExtendWith(Extension1.class)
	@ExtendWith(Extension2.class)
	@interface UseCustomExtensions {
	}

	static class TestClassWithFields {

		@UseCustomExtensions
		static int staticFieldMetaAnnotatedTwice;

		@UseCustomExtensions
		int instanceFieldMetaAnnotatedTwice;

	}

}

[sbrannen]

This has been fixed on main and backported to 5.11.x for inclusion in 5.11.3.

[ppkarwasz]

This has been fixed on main and backported to 5.11.x for inclusion in 5.11.3.

Wow, this was fast! Thank You!