Process extensions registered on non-static fields earlier #3895
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit is truly just an "experiment". The actual "fix" might take a completely different approach. Various tests in ExtensionRegistrationViaParametersAndFieldsTests fail with the changes in this commit. Issue: #3437
marcphilipp
changed the title
This reverts commit f61fdf9.
marcphilipp
force-pushed
the
issues/3437-ExtendWith-on-fields-early-registration
branch
from
da0679f
to
9b5a86a
Compare
marcphilipp
force-pushed
the
issues/3437-ExtendWith-on-fields-early-registration
branch
from
9b5a86a
to
305eaf4
Compare
marcphilipp
changed the title
marcphilipp
deleted the
issues/3437-ExtendWith-on-fields-early-registration
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This PR changes extensions declared via
@ExtendWithon non-static fields to be registered before the test instance is instantiated. Since these declarative extensions are documented to be sorted along with programmatic extensions registered via@RegisterExtensionthe latter are also registered earlier. Since, however, non-static fields are not initialized until the test class is instantiated, this PR introduces the internal concept of "uninitialized extensions" that are registered early and initialized whenever an instance of the test class is created.Fixes #3437. Resolves #3463.
I hereby agree to the terms of the JUnit Contributor License Agreement.
Definition of Done
@APIannotations