Pass kernel environment to cwd_for_path method
#1046
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1046 +/- ##
=======================================
Coverage 73.10% 73.10%
=======================================
Files 64 64
Lines 8274 8274
Branches 1643 1643
=======================================
Hits 6049 6049
Misses 1816 1816
Partials 409 409 ☔ View full report in Codecov by Sentry. |
kevin-bates
approved these changes
Nov 3, 2022
There was a problem hiding this comment.
@divyansshhh - these changes look good. Could you please update your branch and we'll get this merged?
|
I updated the branch |
divyansshhh
added a commit
to divyansshhh/jupyter_server
that referenced
this pull request
Nov 7, 2022
Co-authored-by: Steven Silvester <steven.silvester@ieee.org>
blink1073
added a commit
that referenced
this pull request
Nov 7, 2022
… (#1051) Co-authored-by: Steven Silvester <steven.silvester@ieee.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solved #1045