Backport-1046: Pass kernel environment to cwd_for_path method (#1046)
#1051
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Steven Silvester <steven.silvester@ieee.org>
divyansshhh
changed the title
cwd_for_path method (#1046)cwd_for_path method (#1046)
|
Can we merge this and release a patch from 1.x? |
|
I'll cut a new 1.x once we get #1052 merged |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 1.x #1051 +/- ##
=======================================
Coverage 71.55% 71.55%
=======================================
Files 62 62
Lines 7754 7754
Branches 1172 1172
=======================================
Hits 5548 5548
Misses 1815 1815
Partials 391 391 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Co-authored-by: Steven Silvester steven.silvester@ieee.org