Prefix all extension URLs with base_url (including static) #285
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Zsailer
changed the title
blink1073
reviewed
Aug 24, 2020
blink1073
reviewed
Aug 24, 2020
vidartf
reviewed
Sep 1, 2020
| @@ -45,7 +45,7 @@ def _get_config_dir(user=False, sys_prefix=False): | |||
| return extdir | |||
|
|
|||
|
|
|||
| def _get_extmanager_for_context(user=False, sys_prefix=False): | |||
| def _get_extmanager_for_context(write_dir="jupyter_server_config.d", user=False, sys_prefix=False): | |||
There was a problem hiding this comment.
Sorry for commenting on an old, merged PR, but what is this argument for? It is unused and undocumented in docstring.
Zsailer
added a commit
to Zsailer/jupyter_server
that referenced
this pull request
Nov 18, 2022
hMED22
pushed a commit
to hMED22/jupyter_server
that referenced
this pull request
Jan 23, 2023
Prefix all extension URLs with base_url (including static)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #282.
Adds the base_url as a prefix to all extensions URLs, including the static namespaced URLs.
I've also added a test to check that the static URL is properly prefixed.