Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make config_dir_name in ConfigManager configurable. #297

Merged
merged 1 commit into from
Sep 1, 2020

Conversation

Zsailer
Copy link
Member

@Zsailer Zsailer commented Sep 1, 2020

This generalizes the ConfigManager a bit, so you can point the manager at other config directories (inspired by work happening in JupyterLab config).

Also addressed @vidartf's comment in #285 by using the write_dir argument for setting a config write directory and added a docstring.

Copy link
Contributor

@blink1073 blink1073 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@blink1073 blink1073 merged commit f4c429f into jupyter-server:master Sep 1, 2020
@blink1073
Copy link
Contributor

Released as 1.0.0rc13

@blink1073 blink1073 added this to the 1.0 Release milestone Sep 17, 2020
hMED22 pushed a commit to hMED22/jupyter_server that referenced this pull request Jan 23, 2023
make config_dir_name in ConfigManager configurable.
@Zsailer Zsailer deleted the configmanager branch January 16, 2024 21:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants