Remove some utils now available from jupyter_core 4.6.1, remove pywin32 #357

bollwyvl · 2020-12-10T14:36:01Z

fixes Is pywin32 actually used? #281

This:

setup.py
- removes pywin32
- bumps the minimum jupyter_core to 4.6.1
  - if there were any bugs fixed in ensuing versions in those, we should consider something higher
  - the jupyter_client pin is already sufficient
- removes nose-*, etc. from test deps (needs nose, still, because ipython_genutils)
code
- replaces functions in utils with shim imports
- replaces use of those in the codebase with direct imports
tests
- leaves tests with old imports (for now)
ci
- brings over ci updates (e.g. pypy) from master

follow-ons:

a window should be declared, perhaps with deprecated (gah, a dependency for my deprecated dependencies) for when those would be removed
- the 2.x release seems reasonable, since already planned

recursive-include to grab spec.yaml and favicons

…es callback to _connect

…ort-of-pr-350-on-1.0.x Backport PR jupyter-server#350 on branch 1.0.x (Await _connect and inline read_messages callback to _connect)

Pin 1.0.x to tornado 6.1, remove asyncio patch [backport pieces of jupyter-server#339]

codecov-io · 2020-12-10T14:58:26Z

Codecov Report

Merging #357 (a69b19b) into 1.0.x (aec9947) will decrease coverage by 0.18%.
The diff coverage is 66.66%.

@@            Coverage Diff             @@
##            1.0.x     #357      +/-   ##
==========================================
- Coverage   66.96%   66.78%   -0.19%     
==========================================
  Files          56       56              
  Lines        5513     5467      -46     
  Branches      716      713       -3     
==========================================
- Hits         3692     3651      -41     
- Misses       1593     1594       +1     
+ Partials      228      222       -6

Impacted Files	Coverage Δ
jupyter_server/pytest_plugin.py	`50.33% <0.00%> (+0.33%)`	⬆️
jupyter_server/gateway/handlers.py	`35.92% <28.57%> (+3.47%)`	⬆️
jupyter_server/serverapp.py	`61.88% <80.00%> (+1.46%)`	⬆️
jupyter_server/_version.py	`100.00% <100.00%> (ø)`
jupyter_server/base/handlers.py	`67.04% <100.00%> (-0.61%)`	⬇️
jupyter_server/services/contents/filemanager.py	`69.46% <100.00%> (+0.10%)`	⬆️
jupyter_server/services/kernels/kernelmanager.py	`69.56% <100.00%> (+0.12%)`	⬆️
jupyter_server/utils.py	`69.36% <100.00%> (-6.01%)`	⬇️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 907db90...f456e13. Read the comment docs.

bollwyvl · 2020-12-10T15:36:43Z

Hm, something isn't happy in windows-land...

bollwyvl · 2020-12-10T16:01:32Z

Hah, pip freeze now hanging on win37...

bollwyvl · 2020-12-10T18:43:56Z

Ah, it's (sometimes) hanging on ipykernel. The yak shave continues!

bollwyvl · 2020-12-10T18:54:13Z

ipython/ipykernel#563

bollwyvl · 2020-12-10T21:34:00Z

ipython/ipykernel#564

bollwyvl · 2020-12-11T01:44:28Z

Welp, looks like ipykernel 5.4.0 did not magically fix this...

bollwyvl · 2020-12-11T13:28:46Z

Working on rebuilding a windows VM to see if i can track this down...

Zsailer · 2020-12-11T15:58:10Z

It looks like CI is still grabbing an old version of ipykernel, i.e. 5.3.4. It should be ==5.4.0.

Zsailer · 2020-12-11T15:59:23Z

Oops, nevermind. Apparently I clicked on a previous run.

bollwyvl · 2020-12-12T01:19:11Z

trying with ipykernel 5.4.2...

bollwyvl · 2021-01-05T05:48:53Z

Hm, this appears totally broken now. It probably makes the most sense to start over entirely

…upyter-server#357) * relax session manager to keep synching * Bump to 0.19.3 * update changelog

bollwyvl and others added 14 commits November 19, 2020 15:42

recursive-include to grab spec.yaml

aec9947

Merge pull request jupyter-server#347 from jasongrout/favicon

c7bbafc

recursive-include to grab spec.yaml and favicons

Release 1.0.7

d43ef7f

Backport PR jupyter-server#350: Await _connect and inline read_messag…

1d1a579

…es callback to _connect

Merge pull request jupyter-server#353 from meeseeksmachine/auto-backp…

4141573

…ort-of-pr-350-on-1.0.x Backport PR jupyter-server#350 on branch 1.0.x (Await _connect and inline read_messages callback to _connect)

1.0.8 release

fad6c97

try new tornado hotness

8e6c797

more work on removing asyncio patch

2624a33

updates from review

8ee0b08

fix minimum tornado error message

13fbe06

move min tornado outside translation block

5071b0c

Merge pull request jupyter-server#355 from Zsailer/1.0.x

b4e0474

Pin 1.0.x to tornado 6.1, remove asyncio patch [backport pieces of jupyter-server#339]

Release 1.0.9

907db90

remove some utils now avaialble from jupyter_core, bump pins

da06033

bollwyvl mentioned this pull request Dec 10, 2020

Why no noarch? conda-forge/jupyter_server-feedstock#24

Closed

bollwyvl added 3 commits December 10, 2020 09:39

bring over CI updates from master

8768b62

drop more tests deps

c5bc2c3

restore nose (test dep of ipython_genutils)

2e16bb1

add generous timeout for test step

9cf6da5

bollwyvl added 4 commits December 10, 2020 11:08

hoist (and increase) step timeout

0f38660

hoist (and increase) step timeout, add durations to pytest invocation

d479eab

remove defaults

5c85fe9

remove asyncio patch in test

a69b19b

bollwyvl closed this Dec 11, 2020

bollwyvl reopened this Dec 11, 2020

bollwyvl closed this Dec 12, 2020

bollwyvl reopened this Dec 12, 2020

bollwyvl closed this Jan 5, 2021

bollwyvl reopened this Jan 5, 2021

merge master

f456e13

bollwyvl changed the base branch from 1.0.x to master January 5, 2021 05:41

bollwyvl closed this Jan 5, 2021

Zsailer mentioned this pull request Jan 12, 2021

Replace local secure_write method with jupyter core's #381

Closed

Zsailer added a commit to Zsailer/jupyter_server that referenced this pull request Nov 18, 2022

Relax synchronizer to avoid erroring out when kernel record fails. (j…

b8fbf73

…upyter-server#357) * relax session manager to keep synching * Bump to 0.19.3 * update changelog

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Remove some utils now available from jupyter_core 4.6.1, remove pywin32 #357

Remove some utils now available from jupyter_core 4.6.1, remove pywin32 #357

bollwyvl commented Dec 10, 2020 •

edited

Loading

codecov-io commented Dec 10, 2020 •

edited

Loading

bollwyvl commented Dec 10, 2020

bollwyvl commented Dec 10, 2020

bollwyvl commented Dec 10, 2020

bollwyvl commented Dec 10, 2020

bollwyvl commented Dec 10, 2020

bollwyvl commented Dec 11, 2020

bollwyvl commented Dec 11, 2020

Zsailer commented Dec 11, 2020

Zsailer commented Dec 11, 2020

bollwyvl commented Dec 12, 2020

bollwyvl commented Jan 5, 2021

Remove some utils now available from jupyter_core 4.6.1, remove pywin32 #357

Remove some utils now available from jupyter_core 4.6.1, remove pywin32 #357

Conversation

bollwyvl commented Dec 10, 2020 • edited Loading

codecov-io commented Dec 10, 2020 • edited Loading

Codecov Report

bollwyvl commented Dec 10, 2020

bollwyvl commented Dec 10, 2020

bollwyvl commented Dec 10, 2020

bollwyvl commented Dec 10, 2020

bollwyvl commented Dec 10, 2020

bollwyvl commented Dec 11, 2020

bollwyvl commented Dec 11, 2020

Zsailer commented Dec 11, 2020

Zsailer commented Dec 11, 2020

bollwyvl commented Dec 12, 2020

bollwyvl commented Jan 5, 2021

bollwyvl commented Dec 10, 2020 •

edited

Loading

codecov-io commented Dec 10, 2020 •

edited

Loading