Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid usage of ipython_genutils #718

Merged
merged 2 commits into from
Mar 14, 2022

Conversation

blink1073
Copy link
Contributor

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Mar 12, 2022

Codecov Report

Merging #718 (5ecc1e6) into main (fb25932) will decrease coverage by 0.13%.
The diff coverage is 36.53%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #718      +/-   ##
==========================================
- Coverage   70.94%   70.80%   -0.14%     
==========================================
  Files          62       62              
  Lines        7502     7570      +68     
  Branches     1190     1210      +20     
==========================================
+ Hits         5322     5360      +38     
- Misses       1823     1842      +19     
- Partials      357      368      +11     
Impacted Files Coverage Δ
jupyter_server/_sysinfo.py 80.00% <ø> (-0.65%) ⬇️
jupyter_server/gateway/handlers.py 33.93% <0.00%> (-0.40%) ⬇️
jupyter_server/utils.py 59.33% <24.24%> (-6.58%) ⬇️
jupyter_server/nbconvert/handlers.py 28.57% <33.33%> (-0.52%) ⬇️
jupyter_server/base/zmqhandlers.py 53.22% <50.00%> (-0.50%) ⬇️
jupyter_server/auth/security.py 76.31% <75.00%> (-0.90%) ⬇️
jupyter_server/base/handlers.py 65.72% <100.00%> (ø)
jupyter_server/services/contents/filemanager.py 70.72% <100.00%> (+0.10%) ⬆️
jupyter_server/services/contents/manager.py 88.18% <100.00%> (ø)
jupyter_server/services/kernels/handlers.py 58.86% <100.00%> (-0.09%) ⬇️
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fb25932...5ecc1e6. Read the comment docs.

@blink1073
Copy link
Contributor Author

Once this is merged all of the jupyter_server projects will be off of ipython_genutils. I'm waiting for #723 and getting all green before merging.

@blink1073 blink1073 closed this Mar 14, 2022
@blink1073 blink1073 reopened this Mar 14, 2022
@blink1073
Copy link
Contributor Author

Actually, let's hold off on this one until there is a JupyterLab 3.3.x release with jupyterlab/jupyterlab#12202, since this might break JupyterLab users.

@blink1073 blink1073 marked this pull request as draft March 14, 2022 10:33
@blink1073 blink1073 marked this pull request as ready for review March 14, 2022 14:59
@blink1073 blink1073 merged commit 0fd5c7b into jupyter-server:main Mar 14, 2022
@blink1073 blink1073 deleted the remove_genutils branch March 14, 2022 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants