Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove use of ipython_genutils #12202

Merged
merged 1 commit into from
Mar 14, 2022
Merged

Remove use of ipython_genutils #12202

merged 1 commit into from
Mar 14, 2022

Conversation

blink1073
Copy link
Contributor

@blink1073 blink1073 commented Mar 12, 2022

References

Avoids having an implicit dependency. cf jupyter/nbconvert#1725

Code changes

Removes unnecessary use of ipython_genutils for Python 2 compatibility.

User-facing changes

Avoid installation errors due to missing dependencies.

Backwards-incompatible changes

None

Avoids having an implicit dependency.  cf jupyter/nbconvert#1725
@blink1073 blink1073 added the bug label Mar 12, 2022
@jupyterlab-probot
Copy link

Thanks for making a pull request to jupyterlab!
To try out this branch on binder, follow this link: Binder

@fcollonval fcollonval added this to the 3.3.x milestone Mar 12, 2022
@fcollonval
Copy link
Member

Thanks @blink1073

@fcollonval
Copy link
Member

@meeseeksdev please backport to 3.3.x

meeseeksmachine pushed a commit to meeseeksmachine/jupyterlab that referenced this pull request Mar 12, 2022
@fcollonval fcollonval merged commit 829c276 into master Mar 14, 2022
@fcollonval fcollonval deleted the blink1073-patch-1 branch March 14, 2022 08:09
fcollonval pushed a commit that referenced this pull request Mar 14, 2022
Co-authored-by: Steven Silvester <steven.silvester@ieee.org>
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 15, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants