-
Notifications
You must be signed in to change notification settings - Fork 310
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ensure minimal nbconvert support jinja2 v2 & v3 #756
Conversation
Xref #755 |
Codecov Report
@@ Coverage Diff @@
## main #756 +/- ##
==========================================
- Coverage 70.68% 70.64% -0.04%
==========================================
Files 62 62
Lines 7620 7620
Branches 1218 1218
==========================================
- Hits 5386 5383 -3
- Misses 1860 1861 +1
- Partials 374 376 +2
Continue to review full report at Codecov.
|
Needed to solve minimum constrain test failing because ipykernel request traitlets>=5.1.0 so traitlets==5.0.0 makes it impossible to generate an environment
We're getting hit by pypa/setuptools#3200. I'm working on workarounds for releaser and server now. |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for tracking this down, @fcollonval and @blink1073. Looks good.
Still working through the removal of implicit |
All green except for the flaky windows test. Thanks @fcollonval! |
Thanks @blink1073 for the continuous maintenance. |
Fix https://github.com/jupyter-server/jupyter_server/runs/5681044426?check_suite_focus=true where nbconvert 5.6.1 is used. But jinja2 3.1 was just release and drop some deprecated functions from v2. So requires at least nbconvert 6.2 that handle both jinja2 v2 and v3.