Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure minimal nbconvert support jinja2 v2 & v3 #756

Merged
merged 6 commits into from
Mar 25, 2022

Conversation

fcollonval
Copy link
Member

@fcollonval fcollonval commented Mar 25, 2022

Fix https://github.com/jupyter-server/jupyter_server/runs/5681044426?check_suite_focus=true where nbconvert 5.6.1 is used. But jinja2 3.1 was just release and drop some deprecated functions from v2. So requires at least nbconvert 6.2 that handle both jinja2 v2 and v3.

@fcollonval
Copy link
Member Author

Xref #755

@codecov-commenter
Copy link

codecov-commenter commented Mar 25, 2022

Codecov Report

Merging #756 (71500d5) into main (cd1b1b8) will decrease coverage by 0.03%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #756      +/-   ##
==========================================
- Coverage   70.68%   70.64%   -0.04%     
==========================================
  Files          62       62              
  Lines        7620     7620              
  Branches     1218     1218              
==========================================
- Hits         5386     5383       -3     
- Misses       1860     1861       +1     
- Partials      374      376       +2     
Impacted Files Coverage Δ
jupyter_server/base/zmqhandlers.py 52.91% <0.00%> (-4.24%) ⬇️
jupyter_server/services/kernels/kernelmanager.py 80.63% <0.00%> (-1.91%) ⬇️
jupyter_server/services/kernels/handlers.py 58.86% <0.00%> (-0.22%) ⬇️
jupyter_server/services/contents/manager.py 83.65% <0.00%> (+1.46%) ⬆️
jupyter_server/utils.py 62.20% <0.00%> (+2.87%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cd1b1b8...71500d5. Read the comment docs.

Needed to solve minimum constrain test failing because ipykernel request traitlets>=5.1.0 so traitlets==5.0.0 makes it impossible to generate an environment
@blink1073
Copy link
Contributor

blink1073 commented Mar 25, 2022

We're getting hit by pypa/setuptools#3200. I'm working on workarounds for releaser and server now.

@blink1073
Copy link
Contributor

nbclient 0.5.0 depends on jupyter-client>=6.1.5, we need to bump that as well.

@blink1073 blink1073 closed this Mar 25, 2022
@blink1073 blink1073 reopened this Mar 25, 2022
@blink1073 blink1073 closed this Mar 25, 2022
@blink1073 blink1073 reopened this Mar 25, 2022
Copy link
Member

@Zsailer Zsailer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for tracking this down, @fcollonval and @blink1073. Looks good.

@blink1073
Copy link
Contributor

Looks good.

Still working through the removal of implicit ipython_genutils in various packages. 😅

@blink1073
Copy link
Contributor

All green except for the flaky windows test. Thanks @fcollonval!

@blink1073 blink1073 merged commit acc8ffc into jupyter-server:main Mar 25, 2022
@fcollonval fcollonval deleted the patch-2 branch March 25, 2022 17:04
@fcollonval
Copy link
Member Author

Thanks @blink1073 for the continuous maintenance.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants