-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BUG] Package Dir is No Longer Optional #3200
Labels
Comments
blink1073
added
bug
Needs Triage
Issues that need to be evaluated for severity and status.
labels
Mar 25, 2022
Hi @blink1073 thank you very much for reporting this. I think I found the problem, I am currently having some problems to write a minimal test, but I hope to get it out soon. I will also test wit jupyter server. |
Ah yes, they do seem to be the same error. |
cf jupyter-server/jupyter_server#757 as well. |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
setuptools version
setuptools==61.0.0
Python version
Python 3.8.13
OS
macOS 12.3
Additional environment information
This is happening across python versions and operating systems in CI.
Description
Prior to setuptools 61.0.0,
jupyter_releaser
would properly includejupyter_releaser/schema.json
in the wheel. It is now excluded. We had relied onMANIFEST.in
andinclude_package_data=True
.If I explicitly add the following to the
options
table insetup.cfg
it works, but we did not have to do so previously:The file is included in the sdist.
Expected behavior
We expect the package data to be included.
How to Reproduce
git clone git@github.com:jupyter-server/jupyter_releaser.git
cd jupyter_releaser
pip install build
python -m build --wheel
Output
The text was updated successfully, but these errors were encountered: