[Batch 4] Porting Notebook PRs #99
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Zsailer
commented
Sep 25, 2019
Zsailer
commented
- Enable kernel message filtering jupyter/notebook#4210
- Update session_exists() to account for invalid sessions due to culling jupyter/notebook#4219
- Launch the browser with a redirect file jupyter/notebook#4260
- More selective filename test in list_running_servers jupyter/notebook#4284
kevin-bates
reviewed
Sep 25, 2019
kevin-bates
reviewed
Sep 25, 2019
When kernels are culled, the kernel is terminated in the background, unbeknownst to the session management. As a result, invalid sessions can be produced that appear to exist, yet cannot produce a model from the persisted row due to the associated kernel no longer being active. Prior to this change, these sessions, when encountered via a subsequent call to `get_session()`, would be deleted and a KeyError would be raised. This change updates the existence check to tolerate those kinds of sessions. It removes such sessions (as would happen previously), but rather than raise a KeyError when attempting to convert the row to a dictionary, it logs a warning and returns None, which then allows `session_exists()` to return False since the session was removed (as was ultimately the case previously). Calls to `get_session()` remain just as before and have the potential to raise `KeyError` in such cases. The difference now being that the `KeyError` is accompanied by a message indicating the cause. Fixes #4209
This avoids putting the authentication token into a command-line argument to launch the browser, where it's visible to other users. Filesystem permissions should ensure that only the user who started the notebook can use this route to authenticate. Thanks to Dr Owain Kenway for suggesting this technique.
Tornado 6.0a1 is causing test failures in CI
|
Per the previous comment, this just got added to Notebook. All the more reason to increase the min tornado version: jupyter/notebook#2400 (comment) |
|
No cleanup necessary - the tornado versioning issue was addressed in the last setup of updates: 7a7a3e8 |
Zsailer
pushed a commit
to Zsailer/jupyter_server
that referenced
this pull request
Nov 18, 2022
add status message type wip cleanup fix failing tests wip UI testing finish UI testing bump version
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.