Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Batch 4] Porting Notebook PRs #99

Merged
merged 15 commits into from
Sep 26, 2019
Merged

Commits on Sep 25, 2019

  1. Enable kernel message filtering

    SylvainCorlay authored and Zsailer committed Sep 25, 2019
    Configuration menu
    Copy the full SHA
    c24ecb3 View commit details
    Browse the repository at this point in the history
  2. Update session_exists() to account for invalid sessions due to culling

    When kernels are culled, the kernel is terminated in the background,
    unbeknownst to the session management.  As a result, invalid sessions
    can be produced that appear to exist, yet cannot produce a model from
    the persisted row due to the associated kernel no longer being active.
    Prior to this change, these sessions, when encountered via a subsequent
    call to `get_session()`, would be deleted and a KeyError would be raised.
    
    This change updates the existence check to tolerate those kinds of sessions.
    It removes such sessions (as would happen previously), but rather than
    raise a KeyError when attempting to convert the row to a dictionary,
    it logs a warning and returns None, which then allows `session_exists()`
    to return False since the session was removed (as was ultimately the
    case previously).
    
    Calls to `get_session()` remain just as before and have the potential
    to raise `KeyError` in such cases.  The difference now being that the
    `KeyError` is accompanied by a message indicating the cause.
    
    Fixes #4209
    kevin-bates authored and Zsailer committed Sep 25, 2019
    Configuration menu
    Copy the full SHA
    5a7e159 View commit details
    Browse the repository at this point in the history
  3. Launch the browser with a redirect file

    This avoids putting the authentication token into a command-line
    argument to launch the browser, where it's visible to other users.
    Filesystem permissions should ensure that only the user who started the
    notebook can use this route to authenticate.
    Thanks to Dr Owain Kenway for suggesting this technique.
    takluyver authored and Zsailer committed Sep 25, 2019
    Configuration menu
    Copy the full SHA
    a243228 View commit details
    Browse the repository at this point in the history
  4. Use permanent token in redirect file

    takluyver authored and Zsailer committed Sep 25, 2019
    Configuration menu
    Copy the full SHA
    232fd3d View commit details
    Browse the repository at this point in the history
  5. Point to file in terminal message

    takluyver authored and Zsailer committed Sep 25, 2019
    Configuration menu
    Copy the full SHA
    d3814b1 View commit details
    Browse the repository at this point in the history
  6. Remove one-time token code

    takluyver authored and Zsailer committed Sep 25, 2019
    Configuration menu
    Copy the full SHA
    697533a View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    e7da136 View commit details
    Browse the repository at this point in the history
  8. Convert multiselect test to Selenium

    takluyver authored and Zsailer committed Sep 25, 2019
    Configuration menu
    Copy the full SHA
    41fd432 View commit details
    Browse the repository at this point in the history
  9. Limit to tornado <6 for now

    Tornado 6.0a1 is causing test failures in CI
    takluyver authored and Zsailer committed Sep 25, 2019
    Configuration menu
    Copy the full SHA
    c1c393c View commit details
    Browse the repository at this point in the history
  10. Fix typo in introduction

    wgcostello authored and Zsailer committed Sep 25, 2019
    Configuration menu
    Copy the full SHA
    91b441d View commit details
    Browse the repository at this point in the history
  11. List hidden files if allowed (#3812)

    maxmouchet authored and Zsailer committed Sep 25, 2019
    Configuration menu
    Copy the full SHA
    0883a38 View commit details
    Browse the repository at this point in the history
  12. Upgrade pytest for docs build as well

    takluyver authored and Zsailer committed Sep 25, 2019
    Configuration menu
    Copy the full SHA
    2f3d6f4 View commit details
    Browse the repository at this point in the history
  13. Split logic

    maxmouchet authored and Zsailer committed Sep 25, 2019
    Configuration menu
    Copy the full SHA
    a943e37 View commit details
    Browse the repository at this point in the history
  14. Configuration menu
    Copy the full SHA
    76605ce View commit details
    Browse the repository at this point in the history

Commits on Sep 26, 2019

  1. Configuration menu
    Copy the full SHA
    bb6f244 View commit details
    Browse the repository at this point in the history