Remove deprecated zmq imports (#915)

closes #842
jupyter · Jan 13, 2023 · 3161087 · 3161087
1 parent d6890f2
commit 3161087
Show file tree

Hide file tree

Showing 4 changed files with 2 additions and 4 deletions.
diff --git a/.github/workflows/downstream.yml b/.github/workflows/downstream.yml
@@ -19,7 +19,6 @@ jobs:
       - uses: jupyterlab/maintainer-tools/.github/actions/downstream-test@v1
         with:
           package_name: ipykernel
-          package_spec: "pyqt5 ipykernel[test]"
 
   nbclient:
     runs-on: ubuntu-latest

diff --git a/jupyter_client/ioloop/restarter.py b/jupyter_client/ioloop/restarter.py
@@ -24,7 +24,7 @@ def _loop_default(self):
             DeprecationWarning,
             stacklevel=4,
         )
-        from zmq.eventloop import ioloop
+        from tornado import ioloop
 
         return ioloop.IOLoop.current()
 

diff --git a/jupyter_client/session.py b/jupyter_client/session.py
@@ -28,6 +28,7 @@
 from typing import Optional, Union
 
 import zmq.asyncio
+from tornado.ioloop import IOLoop
 from traitlets import (
     Any,
     Bool,
@@ -45,7 +46,6 @@
 from traitlets.config.configurable import Configurable, LoggingConfigurable
 from traitlets.log import get_logger
 from traitlets.utils.importstring import import_item
-from zmq.eventloop.ioloop import IOLoop
 from zmq.eventloop.zmqstream import ZMQStream
 
 from ._version import protocol_version

diff --git a/tests/test_session.py b/tests/test_session.py
@@ -289,7 +289,6 @@ async def test_tracking(self, session):
         s = session
         s.copy_threshold = 1
         loop = ioloop.IOLoop(make_current=False)
-        ZMQStream(a, io_loop=loop)
 
         msg = s.send(a, "hello", track=False)
         self.assertTrue(msg["tracker"] is ss.DONE)