Remove deprecated zmq imports #915
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hmm, it appears we might have other problems with pyzmq 25. |
|
I'll look into this now! I wouldn't expect issues with this very small release, but nobody ever expects issues. |
|
After isolating pyzmq, it seems this is related to pyqt5 integration changes, and not related to pyzmq at all. |
|
Okay, we do have to fix one test to not pass an asyncio socket to |
|
Aha! The problem is that we were explicitly installing |
Closed
This was referenced Jan 18, 2023
blink1073
added a commit
to blink1073/jupyter_client
that referenced
this pull request
Feb 27, 2024
closes jupyter#842 (cherry picked from commit 3161087)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #842