Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Batch 4] Porting Notebook PRs #99

Merged
merged 15 commits into from
Sep 26, 2019
Merged

Conversation

Copy link
Member

@kevin-bates kevin-bates left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests will fail with update of ServerTestBase references.

jupyter_server/tests/test_serverapp.py Outdated Show resolved Hide resolved
jupyter_server/tests/test_serverapp.py Outdated Show resolved Hide resolved
SylvainCorlay and others added 15 commits September 25, 2019 16:56
When kernels are culled, the kernel is terminated in the background,
unbeknownst to the session management.  As a result, invalid sessions
can be produced that appear to exist, yet cannot produce a model from
the persisted row due to the associated kernel no longer being active.
Prior to this change, these sessions, when encountered via a subsequent
call to `get_session()`, would be deleted and a KeyError would be raised.

This change updates the existence check to tolerate those kinds of sessions.
It removes such sessions (as would happen previously), but rather than
raise a KeyError when attempting to convert the row to a dictionary,
it logs a warning and returns None, which then allows `session_exists()`
to return False since the session was removed (as was ultimately the
case previously).

Calls to `get_session()` remain just as before and have the potential
to raise `KeyError` in such cases.  The difference now being that the
`KeyError` is accompanied by a message indicating the cause.

Fixes #4209
This avoids putting the authentication token into a command-line
argument to launch the browser, where it's visible to other users.
Filesystem permissions should ensure that only the user who started the
notebook can use this route to authenticate.
Thanks to Dr Owain Kenway for suggesting this technique.
Tornado 6.0a1 is causing test failures in CI
Copy link
Member

@kevin-bates kevin-bates left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good - thanks.

@kevin-bates kevin-bates merged commit 3c6eaaf into jupyter-server:master Sep 26, 2019
@kevin-bates
Copy link
Member

#96: commit c1c393c caps tornado < 6. We should probably take a look at this and perhaps even increase the min tornado to >=5.

@kevin-bates
Copy link
Member

Per the previous comment, this just got added to Notebook. All the more reason to increase the min tornado version: jupyter/notebook#2400 (comment)

@kevin-bates
Copy link
Member

No cleanup necessary - the tornado versioning issue was addressed in the last setup of updates: 7a7a3e8

@Zsailer Zsailer deleted the batch-4 branch January 10, 2020 17:35
Zsailer pushed a commit to Zsailer/jupyter_server that referenced this pull request Nov 18, 2022
add status message type

wip

cleanup

fix failing tests

wip UI testing

finish UI testing

bump version
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants