Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change to use a universal Chinese translation on certain words #6218

Merged
merged 1 commit into from
Nov 15, 2021

Conversation

jackexu
Copy link
Contributor

@jackexu jackexu commented Nov 1, 2021

I saw different translations of certain common words like cell and kernel so make it universal.
Also, improve some translation through native tongue

Copy link
Member

@kevin-bates kevin-bates left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Although Google translate is not definitive, I consistly found its translation for the updated text to be closer to the target string than the original translations. For example, where 'cell' is desired, the old translation had 'block', while the update had 'cell'.

I'm approving the updates - thank you @jackexu - and will merge in a day or two barring a strong exception.

@kevin-bates kevin-bates merged commit c923e92 into jupyter:master Nov 15, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 16, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants