-
Notifications
You must be signed in to change notification settings - Fork 362
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MRG] Do not try to build the image with root as the primary user. #676
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Waiting for travis.
Did I draw a short straw and ubuntu removed |
I think it is more likely this was a temporary connection thing as some of the tests passed that use the same docker file 🤞. |
Though there is no good reason to use artful here, so we should switch them to bionic which we use for the rest of repo2docker. |
I can reproduce that locally: |
lol. It looks like the first test "passes" because we expect it to fail and it does, just not because of overallocation of RAM but because there is a problem with building the image. This means your suggestion of "artful support stopped" is probably right. |
OK, will wait for your PR then. |
#677 for updating the base image. |
#677 is merged. If we rebase this PR we should be good to go. This PR is a great example of why it is so hard to estimate how long it will take to do something. "Change up a few lines to give a better error message, child's play!" ... except then we go down the rabbit hole of Ubuntu releases and how the Docker API works :) |
Already did that :) |
Ah yes, I should make use of GitHub snitching on the |
[MRG] Do not try to build the image with root as the primary user.
Fixes #267 and #395. Solution suggested in #267 (comment)