Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not try to build the image with root as the primary user #679

Merged
merged 1 commit into from
May 10, 2019

Conversation

Xarthisius
Copy link
Contributor

This a redo of #676. It errors r2d when root users try to run it without --user-id specified. The difference between this PR and #676 is that check is done against self.user_id. PTAL @betatim

@betatim betatim merged commit 25ebca0 into jupyterhub:master May 10, 2019
@betatim
Copy link
Member

betatim commented May 10, 2019

Let's try this again :)

" --user-name <string> to repo2docker.\n"
"Please see repo2docker --help for more details.\n"
)
sys.exit(errno.EPERM)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since r2d can be used as a library, this code should raise an exception that's caught elsewhere and the message printed. Otherwise, the calling code just exits and can not actually handle anything here.

See #696.

Previously, #496

markmo pushed a commit to markmo/repo2docker that referenced this pull request Jan 22, 2021
…ub#679)

Do not try to build the image with root as the primary user
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants