Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

jlpm run build builds with --development by default #98

Merged
merged 1 commit into from
Oct 23, 2020

Conversation

jtpio
Copy link
Member

@jtpio jtpio commented Sep 25, 2020

@@ -47,7 +47,7 @@
)

cmdclass["jsdeps"] = combine_commands(
install_npm(HERE, build_cmd="build", npm=["jlpm"]),
install_npm(HERE, build_cmd="build:prod", npm=["jlpm"]),
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The bundle shipped with the Python package is still minified.

@jasongrout
Copy link
Contributor

Thanks!

@jasongrout jasongrout merged commit 41bd3ed into jupyterlab:3.0 Oct 23, 2020
@jtpio jtpio deleted the build-dev branch October 23, 2020 19:19
ianhi added a commit to ianhi/widget-ts-cookiecutter that referenced this pull request Feb 27, 2021
ianhi added a commit to ianhi/widget-ts-cookiecutter that referenced this pull request Mar 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants