This repository has been archived by the owner on Aug 8, 2023. It is now read-only.
Use production build for prebuilt extension #33
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @krassowski.
Maybe we should also integrate this cookiecutter into the main TypeScript cookiecutter? Currently the TS cookiecutter can create This might help reduce divergences and lower maintenance efforts. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Quick fix syncing with jupyterlab/extension-cookiecutter-ts#98.
On a related note, I wonder if
build:prodshould also runsclean:labextension(but this is probably for discussion in the main cookiecutter).Edit: I am not confident if this is the way forward; maybe
setup.pyneeds a more general sync with main extension cookiecutter, the scripts diverged quite a bit now.