Update build system and extension IDs to allow disabling/overriding of extensions. #2936
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
afshin
added
pkg:application
pkg:apputils
pkg:cells
pkg:codeeditor
pkg:codemirror
pkg:completer
pkg:console
pkg:coreutils
pkg:csvviewer
pkg:docmanager
pkg:docregistry
pkg:faq
pkg:filebrowser
pkg:fileeditor
pkg:help
pkg:imageviewer
pkg:inspector
pkg:launcher
pkg:markdownviewer
pkg:notebook
pkg:outputarea
pkg:rendermime
pkg:running
pkg:services
pkg:settingeditor
pkg:shortcuts
pkg:tabmanager
pkg:terminal
pkg:themes
labels
… main area of the shell.
|
Thanks! |
This was referenced Oct 5, 2017
Closed
lock
bot
added
the
status:resolved-locked
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes extension ids to have the form
package-name:plugin-name, with schema files taking the formplugin-name.jsonin theschemaDir. We now store the schemas in a nested structure by package name (including scoped packages).Adds a
@jupyterlab/buildutilspackage that for now only provides a mechanism to validate the extensions used and extract their schema and theme files to an appropriate location.We use the new package from the
jupyterlab/,examples/app, and JupyterLabapp-dirso we do not repeat the logic anywhere.