Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase tab width by 50%. #4801

Merged
merged 1 commit into from
Jun 29, 2018

Conversation

ian-r-rose
Copy link
Member

Fixes #2378.

Increases the maximum tab width by 50%, from 144px to 216px. This roughly matches the tab widths in Firefox and Chrome (using the eyeball norm).

cc @tgeorgeux

@jasongrout
Copy link
Contributor

Looks all right to me. Thanks. I'll merge, and @tgeorgeux or @ellisonbg, please comment if you'd rather it be tweaked/changed.

@jasongrout jasongrout merged commit 085e962 into jupyterlab:master Jun 29, 2018
@ellisonbg
Copy link
Contributor

ellisonbg commented Jun 29, 2018 via email

@ian-r-rose
Copy link
Member Author

@ellisonbg
Before:
image
After:
image

@ellisonbg
Copy link
Contributor

ellisonbg commented Jul 3, 2018 via email

@jasongrout
Copy link
Contributor

jasongrout commented Jul 3, 2018

We have autoshrinking if there are too many. That's why there is a min-width as well as a natural base size: https://github.com/jupyterlab/jupyterlab/pull/4801/files#diff-20c095f9c6bf0094b3429901c78d706bR50

@ellisonbg
Copy link
Contributor

ellisonbg commented Jul 3, 2018 via email

@ian-r-rose ian-r-rose mentioned this pull request Jul 20, 2018
@lock lock bot added the status:resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion. label Aug 8, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Aug 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
pkg:application status:resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion. tag:Design and UX
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Increase jp-private-horizontal-tab-width ?
3 participants