-
-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve tab icons in left panel #5920
Conversation
My two cents:
|
Play/pause is a good idea 👍
Looks like there is consensus here...
This is tough... |
I like the idea of play/pause much better than just a play button, but since one can only see and shutdown stuff from the running panel, and not pause/resume it doesn't make total sense. I still like the idea of a power icon, but what about a stop icon? |
I like stop but the material icon for stop is just a square: https://material.io/tools/icons/?search=stop&icon=stop&style=baseline |
A double Chevron also reminds me of a command prompt, which is close to commands in my mind. |
For the running (shutdown/stop menu), we could use a stop icon in a circle: Just spit balling: For the command palette: how about this superpowers icon? The command palette is a place of super powers... On that same theme: a wand I was also think about a "remote" icon, but I can't find a nice one that doesn't look like it is sending a signal. Maybe the adjust icon |
@t-makaro We're currently using Material Icons so let's look for icon candidates in that set vs. Font Awesome 👍 I like the remote control icon for command palette but Material Icons' version is not the best... I updated the description with suggetions from here and #5269. |
I will have a look at this and give some background on how the existing icons were chosen. |
Catching up...
|
05d4f8f
to
11b60a1
Compare
Is there still more to do on this PR? I notice the WIP in the title was removed. |
This current branch replaces the running icon with the stop circle icon (which seems like an improvement to me). It's ready to merge 👍 |
Thanks. It seems that there is confusion in the final changes between remove-circle and stop-circle. Can we take out the remove-circle icon if we aren't using it, and change all the wording to stop-circle? |
9ae7dcf
to
99deb0a
Compare
Can we also remove the CSS classes and SVGs for the "running person" icon? |
Otherwise, I think we should move forwards with this. |
Done! |
Thanks! |
Fixes #5269
To do:
Here are some ideas:
One variation:
Another variation: